Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix printParamRow #2791

Merged
merged 1 commit into from
Jun 23, 2023
Merged

fix printParamRow #2791

merged 1 commit into from
Jun 23, 2023

Conversation

alekseybb197
Copy link
Contributor

What does this change

Fix for Bug #2785 porter param list doesn't display params

Wrong line "cr, ok := v.(DisplayCredentialSet)" was changed to "cr, ok := v.(DisplayParameterSet)"

What issue does it fix

Closes # bug #2785

Notes for the reviewer

Checklist

  • Did you write tests?
  • Did you write documentation?
  • Did you change porter.yaml or a storage document record? Update the corresponding schema file.
  • If this is your first pull request, please add your name to the bottom of our Contributors list. Thank you for making Porter better! 🙇‍♀️

Reviewer Checklist

  • Comment with /azp run test-porter-release if a magefile or build script was modified
  • Comment with /azp run porter-integration if it's a non-trivial PR

@alekseybb197
fix printParamRow
54215f5 
Signed-off-by: Aleksey Barabanov <alekseybb@gmail.com>
@alekseybb197 alekseybb197 mentioned this pull request Jun 22, 2023
Closed
4 tasks
troy0820
troy0820 approved these changes Jun 22, 2023
View reviewed changes
Copy link
Member

@troy0820 troy0820 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is more like it. Nice job @alekseybb197

schristoff
schristoff approved these changes Jun 23, 2023
View reviewed changes
Copy link
Member

@schristoff schristoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whoa! Perfect. Love to see it :)
Enjoy your vacation! ☀️

@schristoff schristoff enabled auto-merge (squash) June 23, 2023 03:07
@schristoff
Copy link
Member

/azp run porter-integration

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@schristoff schristoff merged commit 14c8037 into getporter:main Jun 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@schristoff schristoff schristoff approved these changes

@troy0820 troy0820 troy0820 approved these changes

@sgettys sgettys Awaiting requested review from sgettys sgettys is a code owner

@bdegeeter bdegeeter Awaiting requested review from bdegeeter bdegeeter is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alekseybb197 @schristoff @troy0820