Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: update to go 1.20 #2810

Merged
merged 4 commits into from
Jul 3, 2023
Merged

chore: update to go 1.20 #2810

merged 4 commits into from
Jul 3, 2023

Conversation

schristoff
Copy link
Member

@schristoff schristoff commented Jul 3, 2023 •
edited
Loading

Reviewer Checklist

  • Comment with /azp run test-porter-release if a magefile or build script was modified
  • Comment with /azp run porter-integration if it's a non-trivial PR

@schristoff
update ADO to 1.20 and try and fix docs
d700097 
Signed-off-by: Sarah Christoff <28318173+schristoff@users.noreply.github.com>
@schristoff
rand.Seed deprecated, update porter/magefiles
328e7fc 
Signed-off-by: Sarah Christoff <28318173+schristoff@users.noreply.github.com>
@schristoff
Copy link
Member Author

/azp run test-porter-release

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@schristoff
ctrl+f 1.19.8
565f882 
Signed-off-by: Sarah Christoff <28318173+schristoff@users.noreply.github.com>
@schristoff schristoff mentioned this pull request Jul 3, 2023
Closed
@schristoff schristoff changed the title update ADO to 1.20 and try and fix docs chore: update to go 1.20 Jul 3, 2023
@schristoff
add docs success to automatic
4238ea4 
Signed-off-by: Sarah Christoff <28318173+schristoff@users.noreply.github.com>
troy0820
troy0820 approved these changes Jul 3, 2023
View reviewed changes
Copy link
Member

@troy0820 troy0820 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@schristoff schristoff merged commit 04c2997 into getporter:main Jul 3, 2023
@schristoff schristoff deleted the schristoff_fixdocsado branch July 3, 2023 23:23
@schristoff schristoff mentioned this pull request Sep 22, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@troy0820 troy0820 troy0820 approved these changes

@arschles arschles arschles approved these changes

@sgettys sgettys Awaiting requested review from sgettys sgettys is a code owner

@bdegeeter bdegeeter Awaiting requested review from bdegeeter bdegeeter is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@schristoff @arschles @troy0820