Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added .exe extension for buf download to prevent 404 #2841

Merged
merged 4 commits into from
Jul 27, 2023
Merged

Added .exe extension for buf download to prevent 404 #2841

merged 4 commits into from
Jul 27, 2023

Conversation

ludfjig
Copy link
Contributor

@ludfjig ludfjig commented Jul 26, 2023 •
edited
Loading

What does this change

Fixes a 404 during mage build on windows

What issue does it fix

Closes #2840

Notes for the reviewer

Could also use an if statement and just set the extension to be .exe if os is windows (instead of using ArchiveDownloader)

Checklist

  • Did you write tests?
  • Did you write documentation?
  • Did you change porter.yaml or a storage document record? Update the corresponding schema file.
  • If this is your first pull request, please add your name to the bottom of our Contributors list. Thank you for making Porter better! 🙇‍♀️

Reviewer Checklist

  • Comment with /azp run test-porter-release if a magefile or build script was modified
  • Comment with /azp run porter-integration if it's a non-trivial PR

@ludfjig
added .exe extension
ead1078 
Signed-off-by: Ludvig Liljenberg <lliljenberg@microsoft.com>
@ludfjig
add contributor
d994ef2 
Signed-off-by: Ludvig Liljenberg <lliljenberg@microsoft.com>
@ludfjig
use DownloadArchiveOptions instead
7e7ef29 
Signed-off-by: Ludvig Liljenberg <lliljenberg@microsoft.com>
@ludfjig ludfjig changed the title added .exe extension Added .exe extension for buf download Jul 27, 2023
@ludfjig ludfjig changed the title Added .exe extension for buf download Added .exe extension for buf download to prevent 404 Jul 27, 2023
@ludfjig ludfjig marked this pull request as ready for review July 27, 2023 17:14
@ludfjig
Revert "use DownloadArchiveOptions instead"
e4519b8 
This reverts commit 7e7ef29.

Signed-off-by: Ludvig Liljenberg <lliljenberg@microsoft.com>
@schristoff schristoff merged commit 8e21833 into getporter:main Jul 27, 2023
@ludfjig ludfjig deleted the ludvig-build-fix branch July 27, 2023 19:35
AGMETEOR pushed a commit to AGMETEOR/porter that referenced this pull request Aug 9, 2023
@ludfjig
Added .exe extension for buf download to prevent 404 (getporter#2841)
fc9fc19 
* added .exe extension

Signed-off-by: Ludvig Liljenberg <lliljenberg@microsoft.com>
Signed-off-by: Allan Guwatudde <allan@Allans-MacBook-Pro.local>
AGMETEOR pushed a commit to AGMETEOR/porter that referenced this pull request Aug 9, 2023
@ludfjig
Added .exe extension for buf download to prevent 404 (getporter#2841)
9478071 
* added .exe extension

Signed-off-by: Ludvig Liljenberg <lliljenberg@microsoft.com>
Signed-off-by: Allan Guwatudde <allan@Allans-MacBook-Pro.local>
AGMETEOR pushed a commit to AGMETEOR/porter that referenced this pull request Aug 9, 2023
@ludfjig
Added .exe extension for buf download to prevent 404 (getporter#2841)
550ae44 
* added .exe extension

Signed-off-by: Ludvig Liljenberg <lliljenberg@microsoft.com>
Signed-off-by: Allan Guwatudde <allan@Allans-MacBook-Pro.local>
AGMETEOR pushed a commit to AGMETEOR/porter that referenced this pull request Aug 9, 2023
@ludfjig
Added .exe extension for buf download to prevent 404 (getporter#2841)
9cc829e 
* added .exe extension

Signed-off-by: Ludvig Liljenberg <lliljenberg@microsoft.com>
Signed-off-by: Allan Guwatudde <allan@Allans-MacBook-Pro.local>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@schristoff schristoff schristoff approved these changes

@sgettys sgettys Awaiting requested review from sgettys sgettys is a code owner

@bdegeeter bdegeeter Awaiting requested review from bdegeeter bdegeeter is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bug: 404 during "mage Build" on windows
2 participants
@ludfjig @schristoff