Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added bundle name to jaeger command #2850

Merged
merged 1 commit into from
Aug 1, 2023
Merged

Conversation

ludfjig
Copy link
Contributor

@ludfjig ludfjig commented Jul 31, 2023

What does this change

Adds a name to the installed bundle so it doesn't show up as empty, see issue below

What issue does it fix

Closes #2849

Notes for the reviewer

None

Checklist

  • Did you write tests?
  • Did you write documentation?
  • Did you change porter.yaml or a storage document record? Update the corresponding schema file.
  • If this is your first pull request, please add your name to the bottom of our Contributors list. Thank you for making Porter better! 🙇‍♀️

Reviewer Checklist

  • Comment with /azp run test-porter-release if a magefile or build script was modified
  • Comment with /azp run porter-integration if it's a non-trivial PR

Signed-off-by: Ludvig Liljenberg <lliljenberg@microsoft.com>
@schristoff schristoff merged commit e961725 into getporter:main Aug 1, 2023
ludfjig added a commit to ludfjig/porter that referenced this pull request Aug 1, 2023
added bundle name to command

Signed-off-by: Ludvig Liljenberg <lliljenberg@microsoft.com>
AGMETEOR pushed a commit to AGMETEOR/porter that referenced this pull request Aug 9, 2023
added bundle name to command

Signed-off-by: Ludvig Liljenberg <lliljenberg@microsoft.com>
Signed-off-by: Allan Guwatudde <allan@Allans-MacBook-Pro.local>
AGMETEOR pushed a commit to AGMETEOR/porter that referenced this pull request Aug 9, 2023
added bundle name to command

Signed-off-by: Ludvig Liljenberg <lliljenberg@microsoft.com>
Signed-off-by: Allan Guwatudde <allan@Allans-MacBook-Pro.local>
AGMETEOR pushed a commit to AGMETEOR/porter that referenced this pull request Aug 9, 2023
added bundle name to command

Signed-off-by: Ludvig Liljenberg <lliljenberg@microsoft.com>
Signed-off-by: Allan Guwatudde <allan@Allans-MacBook-Pro.local>
AGMETEOR pushed a commit to AGMETEOR/porter that referenced this pull request Aug 9, 2023
added bundle name to command

Signed-off-by: Ludvig Liljenberg <lliljenberg@microsoft.com>
Signed-off-by: Allan Guwatudde <allan@Allans-MacBook-Pro.local>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Docs / Bug: Installing jaeger from Contributing Guide leads to bundle with no name
2 participants