Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: fix jq url in image #2853

Merged
merged 5 commits into from
Aug 3, 2023
Merged

Conversation

schristoff
Copy link
Member

fixes #2852

Reviewer Checklist

  • Comment with /azp run test-porter-release if a magefile or build script was modified
  • Comment with /azp run porter-integration if it's a non-trivial PR

Signed-off-by: Sarah Christoff <28318173+schristoff@users.noreply.github.com>
Signed-off-by: Sarah Christoff <28318173+schristoff@users.noreply.github.com>
Copy link
Member

@troy0820 troy0820 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: Sarah Christoff <28318173+schristoff@users.noreply.github.com>
Signed-off-by: Sarah Christoff <28318173+schristoff@users.noreply.github.com>
…ut maybe it's actually broken.

Signed-off-by: Sarah Christoff <28318173+schristoff@users.noreply.github.com>
@schristoff schristoff merged commit b354306 into getporter:main Aug 3, 2023
@schristoff schristoff deleted the schristoff_iss2852 branch August 3, 2023 02:33
AGMETEOR pushed a commit to AGMETEOR/porter that referenced this pull request Aug 9, 2023
bug: fix jq url in image

---------

Signed-off-by: Sarah Christoff <28318173+schristoff@users.noreply.github.com>
Signed-off-by: Allan Guwatudde <allan@Allans-MacBook-Pro.local>
AGMETEOR pushed a commit to AGMETEOR/porter that referenced this pull request Aug 9, 2023
bug: fix jq url in image

---------

Signed-off-by: Sarah Christoff <28318173+schristoff@users.noreply.github.com>
Signed-off-by: Allan Guwatudde <allan@Allans-MacBook-Pro.local>
AGMETEOR pushed a commit to AGMETEOR/porter that referenced this pull request Aug 9, 2023
bug: fix jq url in image

---------

Signed-off-by: Sarah Christoff <28318173+schristoff@users.noreply.github.com>
Signed-off-by: Allan Guwatudde <allan@Allans-MacBook-Pro.local>
AGMETEOR pushed a commit to AGMETEOR/porter that referenced this pull request Aug 9, 2023
bug: fix jq url in image

---------

Signed-off-by: Sarah Christoff <28318173+schristoff@users.noreply.github.com>
Signed-off-by: Allan Guwatudde <allan@Allans-MacBook-Pro.local>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: TestExecOutput Fails
2 participants