Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docs: fixed broken links #2867

Merged
merged 8 commits into from
Aug 16, 2023
Merged

Docs: fixed broken links #2867

merged 8 commits into from
Aug 16, 2023

Conversation

ludfjig
Copy link
Contributor

@ludfjig ludfjig commented Aug 7, 2023 •
edited
Loading

What does this change

Fixes 404s in docs.

What issue does it fix

Closes #2866

Notes for the reviewer

Put any questions or notes for the reviewer here.

Checklist

  • Did you write tests?
  • Did you write documentation?
  • Did you change porter.yaml or a storage document record? Update the corresponding schema file.
  • If this is your first pull request, please add your name to the bottom of our Contributors list. Thank you for making Porter better! 🙇‍♀️

Reviewer Checklist

  • Comment with /azp run test-porter-release if a magefile or build script was modified
  • Comment with /azp run porter-integration if it's a non-trivial PR

@ludfjig
fixed broken links
501c720 
Signed-off-by: Ludvig Liljenberg <lliljenberg@microsoft.com>
@ludfjig
more broken links fixed
de4705e 
Signed-off-by: Ludvig Liljenberg <lliljenberg@microsoft.com>
@ludfjig
json schema fix
4ee1241 
Signed-off-by: Ludvig Liljenberg <lliljenberg@microsoft.com>
@ludfjig
more broken links
55fece4 
Signed-off-by: Ludvig Liljenberg <lliljenberg@microsoft.com>
@ludfjig ludfjig marked this pull request as ready for review August 8, 2023 19:40
@ludfjig
fix mistakes
11df8a8 
Signed-off-by: Ludvig Liljenberg <lliljenberg@microsoft.com>
@troy0820 troy0820 added the docs Markdown ahoy! Updates needed on porter.sh or in dev docs. label Aug 10, 2023
@ludfjig
small fix
ab2949e 
Signed-off-by: Ludvig Liljenberg <lliljenberg@microsoft.com>
@ludfjig ludfjig requested a review from troy0820 as a code owner August 11, 2023 20:42
ludfjig and others added 2 commits August 16, 2023 15:58
@ludfjig
last todo
2f9a384 
Signed-off-by: Ludvig Liljenberg <lliljenberg@microsoft.com>
@schristoff
Merge branch 'main' into docs_links
30e9d5c
@schristoff schristoff merged commit 235807a into getporter:main Aug 16, 2023
5 checks passed
@ludfjig ludfjig deleted the docs_links branch August 16, 2023 23:51
alekseybb197 pushed a commit to alekseybb197/porter that referenced this pull request Sep 22, 2023
@ludfjig @alekseybb197
Docs: fixed broken links (getporter#2867)
c63dc5f 
* fixed broken links

Signed-off-by: Ludvig Liljenberg <lliljenberg@microsoft.com>
---------

Signed-off-by: Ludvig Liljenberg <lliljenberg@microsoft.com>

Signed-off-by: Ludvig Liljenberg <ludfjig@hotmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@schristoff schristoff schristoff approved these changes

@sgettys sgettys Awaiting requested review from sgettys sgettys is a code owner

@bdegeeter bdegeeter Awaiting requested review from bdegeeter bdegeeter is a code owner

@troy0820 troy0820 Awaiting requested review from troy0820 troy0820 is a code owner

Assignees
No one assigned
Labels
docs Markdown ahoy! Updates needed on porter.sh or in dev docs.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Docs: fix broken links
3 participants
@ludfjig @schristoff @troy0820