Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Fix broken links on CONTRIBUTING.md #2918

Merged
merged 3 commits into from
Sep 21, 2023
Merged

docs: Fix broken links on CONTRIBUTING.md #2918

merged 3 commits into from
Sep 21, 2023

Conversation

gonmmarques
Copy link
Contributor

@gonmmarques gonmmarques commented Sep 20, 2023

What does this change

Hello there, I notice this issue #2907. And indeed if you go to Porter contribute page https://getporter.org/contribute/ you will see those links leading to a 404 on GitHub.
This addresses that.

What issue does it fix

Closes #2907.

Notes for the reviewer

Let me know if I missed something as this is my first PR.

Checklist

  • Did you write tests?
  • Did you write documentation?
  • Did you change porter.yaml or a storage document record? Update the corresponding schema file.
  • If this is your first pull request, please add your name to the bottom of our Contributors list. Thank you for making Porter better! 🙇‍♀️

Reviewer Checklist

  • Comment with /azp run test-porter-release if a magefile or build script was modified
  • Comment with /azp run porter-integration if it's a non-trivial PR

Signed-off-by: Gonçalo Montalvão Marques <9379664+gonmmarques@users.noreply.github.com>
gonmmarques and others added 2 commits September 20, 2023 09:18
Signed-off-by: Gonçalo Montalvão Marques <9379664+gonmmarques@users.noreply.github.com>
@schristoff
Copy link
Member

Hey @gonmmarques - thank you so much for this contributor to Porter! We've been wrestling with these 404s since we have re-organized our documentation, so I can't understate how helpful this is!

@schristoff schristoff merged commit b5ca08c into getporter:main Sep 21, 2023
7 checks passed
@gonmmarques gonmmarques deleted the patch-1 branch September 21, 2023 07:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Reporting Broken Links on getporter.org contribute guide Doc
2 participants