-
Notifications
You must be signed in to change notification settings - Fork 208
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(docs) expand more on the "default" field for parameters #2927
(docs) expand more on the "default" field for parameters #2927
Conversation
Signed-off-by: schristoff <28318173+schristoff@users.noreply.github.com>
docs/content/wiring.md
Outdated
@@ -51,6 +51,15 @@ You can also provide any other attributes, as specified by the CNAB [parameters] | |||
default: "wordpress" | |||
``` | |||
|
|||
If using the default parameter field it must be set. However, it must be passed in as an empty |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it's not clear to me what these two sentences mean, maybe could be clearer?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure! Is there an exact part that is confusing to you?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What does "it must be set" mean, and why you gotta set them to some empty value
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
how about the following:
If you decide to use the default parameter field, you must set it as the empty value
does this capture everything you want to say?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I still dont understand why it has to be empty. Isn't this in contradiction with the above example?
Lines 46 to 52 in 1adfb99
You can also provide any other attributes, as specified by the CNAB [parameters](https://github.com/cnabio/cnab-spec/blob/master/101-bundle-json.md#parameters) specification. To specify a default value, for example, you could provide the following parameter definition: | |
```yaml | |
- name: database_name | |
type: string | |
default: "wordpress" | |
``` |
docs/content/wiring.md
Outdated
@@ -51,6 +51,15 @@ You can also provide any other attributes, as specified by the CNAB [parameters] | |||
default: "wordpress" | |||
``` | |||
|
|||
If using the default parameter field it must be set. However, it must be passed in as an empty |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
how about the following:
If you decide to use the default parameter field, you must set it as the empty value
does this capture everything you want to say?
Signed-off-by: schristoff <28318173+schristoff@users.noreply.github.com>
No description provided.