Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(chore) Comment out flake in TestRebuild, update high sev deps #2947

Merged
merged 2 commits into from
Oct 19, 2023
Merged

(chore) Comment out flake in TestRebuild, update high sev deps #2947

merged 2 commits into from
Oct 19, 2023

Conversation

schristoff
Copy link
Member

No description provided.

@schristoff schristoff marked this pull request as ready for review October 19, 2023 03:30
@schristoff
Copy link
Member Author

/azp run porter-integration

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@devigned devigned mentioned this pull request Oct 19, 2023
Closed
devigned
devigned approved these changes Oct 19, 2023
View reviewed changes
Copy link
Member

@devigned devigned left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! I've created a follow up issue linked to this PR to ensure the flakey test is not forgotten about.

@schristoff schristoff merged commit c17c085 into getporter:main Oct 19, 2023
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@devigned devigned devigned approved these changes

@sgettys sgettys Awaiting requested review from sgettys sgettys is a code owner

@bdegeeter bdegeeter Awaiting requested review from bdegeeter bdegeeter is a code owner

@troy0820 troy0820 Awaiting requested review from troy0820 troy0820 is a code owner

@arschles arschles Awaiting requested review from arschles

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@schristoff @devigned