Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(chore): cleanup ado, add badge #2966

Merged
merged 11 commits into from
Jan 31, 2024
Merged

(chore): cleanup ado, add badge #2966

merged 11 commits into from
Jan 31, 2024

Conversation

schristoff
Copy link
Member

No description provided.

@schristoff
(chore): cleanup ado, add badge
4fd6fb2 
Signed-off-by: Sarah Christoff <28318173+schristoff@users.noreply.github.com>
@schristoff
keep some things just in case
d64977e 
Signed-off-by: Sarah Christoff <28318173+schristoff@users.noreply.github.com>
@schristoff
whoops
268cc59 
Signed-off-by: Sarah Christoff <28318173+schristoff@users.noreply.github.com>
@schristoff
add images back, and update some of the files
db47a7a 
Signed-off-by: Sarah Christoff <28318173+schristoff@users.noreply.github.com>
@schristoff
why r u mad
4e0b52a 
Signed-off-by: Sarah Christoff <28318173+schristoff@users.noreply.github.com>
@schristoff
readd bundle.json
79cefaa 
Signed-off-by: Sarah Christoff <28318173+schristoff@users.noreply.github.com>
@schristoff
remove .github/images and keep testdata/images
7c1838d 
Signed-off-by: Sarah Christoff <28318173+schristoff@users.noreply.github.com>
@schristoff
oh this is why it was failing
9baebc1 
Signed-off-by: Sarah Christoff <28318173+schristoff@users.noreply.github.com>
@schristoff
set if false explicitly
623cb06 
Signed-off-by: Sarah Christoff <28318173+schristoff@users.noreply.github.com>
@schristoff
Merge branch 'main' into schristoff_byeado
9b4f451
troy0820
troy0820 approved these changes Jan 30, 2024
View reviewed changes
Copy link
Member

@troy0820 troy0820 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM. The rename of the file is a nit and it's non-blocking.

.github/workflows/porter-install-check.yml Show resolved Hide resolved
build/testdata/bundles/mysql/.cnab/bundle.json Outdated Show resolved Hide resolved
.github/workflows/build_azure_pipelinesrelease_template.yml Show resolved Hide resolved
@schristoff
rm azure
395ed9d 
Signed-off-by: Sarah Christoff <28318173+schristoff@users.noreply.github.com>
@schristoff schristoff merged commit 08de9eb into getporter:main Jan 31, 2024
21 checks passed
@schristoff schristoff deleted the schristoff_byeado branch January 31, 2024 19:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@troy0820 troy0820 troy0820 approved these changes

@sgettys sgettys Awaiting requested review from sgettys sgettys is a code owner

@bdegeeter bdegeeter Awaiting requested review from bdegeeter bdegeeter is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@schristoff @troy0820