Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove parameter from installation if parameter is removed from bundle #3012

Merged
merged 2 commits into from
Mar 13, 2024
Merged

Remove parameter from installation if parameter is removed from bundle #3012

merged 2 commits into from
Mar 13, 2024

Conversation

kichristensen
Copy link
Contributor

What does this change

Remove parameter from installation if parameter is removed from bundle.
Otherwise it is not possible to upgrade to a version of bundle where parameters are removed since the last installation.

What issue does it fix

Closes #2929

Checklist

  • Did you write tests?
  • Did you write documentation?
  • Did you change porter.yaml or a storage document record? Update the corresponding schema file.
  • If this is your first pull request, please add your name to the bottom of our Contributors list. Thank you for making Porter better! 🙇‍♀️

Reviewer Checklist

  • Comment with /azp run test-porter-release if a magefile or build script was modified
  • Comment with /azp run porter-integration if it's a non-trivial PR

@kichristensen
Remove installation parameter if parameter is removed from bundle
fee4f53 
Otherwise it is not possible to upgrade to a version of bundle where
parameters are removed since the last installation.

Signed-off-by: Kim Christensen <kimworking@gmail.com>
@schristoff
Copy link
Member

schristoff commented Mar 10, 2024 •
edited
Loading

One second and I'll re-kickoff the tests
Update: Reverted what was merged into main that was causing failed tests!

schristoff
schristoff approved these changes Mar 13, 2024
View reviewed changes
Copy link
Member

@schristoff schristoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've poked at this a bit locally and it looks good. :)

@schristoff schristoff merged commit a6a5ca4 into getporter:main Mar 13, 2024
15 checks passed
@kichristensen kichristensen deleted the removeParametersSubsequentVersion branch April 9, 2024 22:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@schristoff schristoff schristoff approved these changes

@sgettys sgettys Awaiting requested review from sgettys sgettys is a code owner

@bdegeeter bdegeeter Awaiting requested review from bdegeeter bdegeeter is a code owner

@troy0820 troy0820 Awaiting requested review from troy0820 troy0820 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cannot remove parameters in subsequent versions of bundles
2 participants
@kichristensen @schristoff