Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change
Fixes the porter-canary action so it can run when changes are pushed to
main
orrelease/*
branches.Also removes the workflow_dispatch trigger, but that is up for discussion as it also removes the functionality to manually trigger the action if needed.
And for readability names is added to the integration test steps.
What issue does it fix
Closes #3073
Notes for the reviewer
It is hard to test if it works a 100% as I cannot run or trigger the action in the porter repository to see the full flow, and check if everything is pushed as it should be.
As mentioned the removal of the workflow_dispatch trigger is up for discussion, as it removes the ability to manually run the action if needed. But if we want it to stay, then conditions on the jobs on job needs to be introduced, as inputs can only be passed on when through workflow_dispatch, which is not pretty in YAML or in the action view. So it would look something like this:
Checklist