Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Run integration tests on PR #3126

Merged
merged 2 commits into from
May 22, 2024
Merged

Run integration tests on PR #3126

merged 2 commits into from
May 22, 2024

Conversation

kichristensen
Copy link
Contributor

@kichristensen kichristensen commented May 21, 2024 •
edited
Loading

What does this change

Run integration tests on PR

Notes for the reviewer

The number of check actions on a PR increases a lot, but I think that is okay compared to the value it provides

Checklist

  • Did you write tests?
  • Did you write documentation?
  • Did you change porter.yaml or a storage document record? Update the corresponding schema file.
  • If this is your first pull request, please add your name to the bottom of our Contributors list. Thank you for making Porter better! 🙇‍♀️

@kichristensen
Run integration tests on PR
14daffc 
Signed-off-by: Kim Christensen <kimworking@gmail.com>
@kichristensen kichristensen marked this pull request as ready for review May 21, 2024 21:59
schristoff
schristoff approved these changes May 21, 2024
View reviewed changes
Copy link
Member

@schristoff schristoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤦‍♀️ thank you for fixing my bug

@kichristensen kichristensen merged commit 1aeafb0 into getporter:main May 22, 2024
30 of 36 checks passed
@kichristensen kichristensen deleted the runIntegrationTestsOnPr branch May 22, 2024 10:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@schristoff schristoff schristoff approved these changes

@sgettys sgettys Awaiting requested review from sgettys sgettys is a code owner

@bdegeeter bdegeeter Awaiting requested review from bdegeeter bdegeeter is a code owner

@troy0820 troy0820 Awaiting requested review from troy0820 troy0820 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kichristensen @schristoff