Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check if CLI docs have been committed during CI #3132

Merged
merged 5 commits into from
May 28, 2024

Conversation

kichristensen
Copy link
Contributor

What does this change

As CLI reference docs is generated during build, we should ensure that they have been committed and pushed whenever a they are changed.

What issue does it fix

Closes #551

Notes for the reviewer

Checklist

  • Did you write tests?
  • Did you write documentation?
  • Did you change porter.yaml or a storage document record? Update the corresponding schema file.
  • If this is your first pull request, please add your name to the bottom of our Contributors list. Thank you for making Porter better! 🙇‍♀️

AS CLI reference docs is generated during build, we should ensure that
they have been committed and pushed whenever a they are changed.

Signed-off-by: Kim Christensen <kimworking@gmail.com>
@kichristensen kichristensen force-pushed the checkCliDocsCommitted branch 2 times, most recently from a45cba1 to 18c2a0e Compare May 26, 2024 19:26
@kichristensen kichristensen marked this pull request as ready for review May 26, 2024 19:43
@schristoff schristoff merged commit e5e562f into getporter:main May 28, 2024
37 checks passed
@kichristensen kichristensen deleted the checkCliDocsCommitted branch June 3, 2024 21:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Verify that the CLI docs were updated during CI
2 participants