-
Notifications
You must be signed in to change notification settings - Fork 201
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added validation if someone specifies a version on a bundle #3148
Open
dgannon991
wants to merge
7
commits into
getporter:main
Choose a base branch
from
dgannon991:feat/3136/mixin-version-support
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
4ebfb8e
WIP: Added validation if someone specifies a version on a bundle
dgannon991 b5deb8e
Swapped to existing install of semver!
dgannon991 757497d
Added test for missing mixin, still need to add more
dgannon991 e36bd99
Added tests for semvers
dgannon991 bb0cf39
Added comment above heler variables
dgannon991 d4b4a94
Merge branch 'main' into feat/3136/mixin-version-support
dgannon991 34cea2f
Improved error assertion in semver tests
dgannon991 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are there currently anything ensuring that mixins cannot use a config field called
version
?I'm thinking of the situation where mixins already provide a field called
version
, which might result in unintended behaviourThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, it was simply the suggested field name on the issue. We could always use
mixinVersion
or something more verbose to avoid clashing?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I personally like
version
the best, but it could break some existing plugins.@schristoff do you know of any way we can easily handle a "reservation" of a mixin configuration property?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kichristensen, @schristoff could a similar approach such as porter-state, porter-debug be taken?
![image](https://private-user-images.githubusercontent.com/26071258/339451357-0649f8b5-bcdf-45dc-9b05-57419a9fff04.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjQ1ODkzMTUsIm5iZiI6MTcyNDU4OTAxNSwicGF0aCI6Ii8yNjA3MTI1OC8zMzk0NTEzNTctMDY0OWY4YjUtYmNkZi00NWRjLTliMDUtNTc0MTlhOWZmZjA0LnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA4MjUlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwODI1VDEyMzAxNVomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTU5NzNhOGUyZWQxYTA4NjBmYWRlM2I0ZTIzNTBmOTAxNmNlYjMyN2RkYzQ0OWRhZmI2MzQ4OWY1M2E1OWJjMjQmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.RpfzZi29jjmazImAO3bM03XWmN-zmrVTBdjJgDqmjjY)