Fix canary build of the server image #3174
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Building and publishing the server image during a canary build, did not use the canary tag, instead it used the version of the build, e.g., v1.1.0-7-gd0387ecb. It also means that on each canary build a new tag is used when publishing the image. By checking if we are doing a release of a tagged version or a canary build we can use the correct tag. Signed-off-by: Kim Christensen <kimworking@gmail.com>
kichristensen
requested review from
schristoff,
sgettys,
bdegeeter and
troy0820
as code owners
schristoff
approved these changes
Jul 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change
Building and publishing the server image during a canary build, did not use the canary tag, instead it used the version of the build, e.g., v1.1.0-7-gd0387ecb. It also means that on each canary build a new tag is used when publishing the image.
By checking if we are doing a release of a tagged version or a canary build we can use the correct tag.
Checklist