update code fences and remove prompt indicator #3181
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: dejanualex <dejanualexandru@gmail.com>
dejanu
requested review from
schristoff,
sgettys,
bdegeeter,
troy0820 and
kichristensen
as code owners
|
@dejanu Thank you so much for the PR, it looks good to me. |
Signed-off-by: dejanualex <dejanualexandru@gmail.com>
Signed-off-by: dejanualex <dejanualexandru@gmail.com>
kichristensen
approved these changes
Jul 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change
Update the code fence and remove the prompt indicator from porter cmds, since users will copy the command including the
$, and when pasting the command, they must manually remove the prompt indicator.What issue does it fix
Closes #3180
Notes for the reviewer
TBH the issue appears in other parts of the documentation, but before making updates on multiple pages, I wanted to gather additional feedback