Add a call to MkdirAll for the credentials directory path. #381
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds a call to MkdirAll with the credentials path before we attempt to write the credential file. This will ensure that the credential directory exists before we try and write the file. If the directory exists already, it's a NO-OP. Fixes getporter#377
vdice
approved these changes
Jun 5, 2019
carolynvs
reviewed
Jun 5, 2019
| } | ||
| // Make the credentials path if it doesn't exist. MkdirAll does nothing if it already exists | ||
| // Readable, writable only by the user | ||
| err = p.Config.FileSystem.MkdirAll(credentialsDir, 0700) |
There was a problem hiding this comment.
This isn't handling the error, can you add that quick?
There was a problem hiding this comment.
yeahhhh i have that in a commit i noticed it wasn't there after i pusheddddd
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a call to MkdirAll with the credentials path before we attempt to write the credential file. This will ensure that the credential directory exists before we try and write the file. If the directory exists already, it's a NO-OP.
Fixes #377