Map sensitive to writeOnly when converting to bundle.json

pkg/cnab/config_adapter/adapter.go

@@ -139,6 +139,10 @@ func (c *ManifestConverter) generateBundleParameters(defs *definition.Definition
 			p.Required = true
 		}
 
+		if param.Sensitive {
+			param.Schema.WriteOnly = toBool(true)
+		}
+
 		if param.Destination != nil {
 			p.Destination = &bundle.Location{
 				EnvironmentVariable: param.Destination.EnvironmentVariable,
@@ -176,6 +180,10 @@ func (c *ManifestConverter) generateBundleOutputs(defs *definition.Definitions)
 				Path:        filepath.Join(config.BundleOutputsDir, output.Name),
 			}
 
+			if output.Sensitive {
+				output.Schema.WriteOnly = toBool(true)
+			}
+
 			// Only set definition if it doesn't already exist
 			// (Both Params and Outputs may reference same Definition)
 			if _, exists := (*defs)[output.Name]; !exists {
@@ -269,3 +277,11 @@ func (c *ManifestConverter) generateDependencies() *extensions.Dependencies {
 
 	return deps
 }
+
+func toBool(value bool) *bool {
+	return &value
+}
+
+func toFloat64(v float64) *float64 {
+	return &v
+}

pkg/cnab/config_adapter/adapter_test.go

@@ -44,10 +44,6 @@ func TestManifestConverter_ToBundle(t *testing.T) {
 	assert.Nil(t, bun.Outputs, "expected outputs section not to exist in generated bundle")
 }
 
-func makefloat64(v float64) *float64 {
-	return &v
-}
-
 func TestManifestConverter_generateBundleParametersSchema(t *testing.T) {
 	c := config.NewTestConfig(t)
 	c.TestContext.AddTestFile("testdata/porter-with-parameters.yaml", config.Name)
@@ -78,8 +74,8 @@ func TestManifestConverter_generateBundleParametersSchema(t *testing.T) {
 			definition.Schema{
 				Type:    "integer",
 				Default: 1,
-				Minimum: makefloat64(0),
-				Maximum: makefloat64(10),
+				Minimum: toFloat64(0),
+				Maximum: toFloat64(10),
 			},
 		},
 		{"anumber",
@@ -92,8 +88,8 @@ func TestManifestConverter_generateBundleParametersSchema(t *testing.T) {
 			definition.Schema{
 				Type:             "number",
 				Default:          0.5,
-				ExclusiveMinimum: makefloat64(0),
-				ExclusiveMaximum: makefloat64(1),
+				ExclusiveMinimum: toFloat64(0),
+				ExclusiveMaximum: toFloat64(1),
 			},
 		},
 		{
@@ -121,8 +117,8 @@ func TestManifestConverter_generateBundleParametersSchema(t *testing.T) {
 			},
 			definition.Schema{
 				Type:      "string",
-				MinLength: makefloat64(1),
-				MaxLength: makefloat64(10),
+				MinLength: toFloat64(1),
+				MaxLength: toFloat64(10),
 			},
 		},
 		{
@@ -154,6 +150,20 @@ func TestManifestConverter_generateBundleParametersSchema(t *testing.T) {
 				Type: "boolean",
 			},
 		},
+		{
+			"sensitive",
+			bundle.Parameter{
+				Definition: "sensitive",
+				Destination: &bundle.Location{
+					EnvironmentVariable: "SENSITIVE",
+				},
+				Required: true,
+			},
+			definition.Schema{
+				Type:      "string",
+				WriteOnly: toBool(true),
+			},
+		},
 	}
 
 	for _, tc := range testcases {
@@ -290,6 +300,7 @@ func TestManifestConverter_generateBundleOutputs(t *testing.T) {
 				Type:        "string",
 				Description: "Description of output1",
 			},
+			Sensitive: true,
 		},
 		{
 			Name: "output2",
@@ -329,6 +340,7 @@ func TestManifestConverter_generateBundleOutputs(t *testing.T) {
 		"output1": &definition.Schema{
 			Type:        "string",
 			Description: "Description of output1",
+			WriteOnly:   toBool(true),
 		},
 		"output2": &definition.Schema{
 			Type:        "boolean",

pkg/cnab/config_adapter/testdata/porter-with-parameters.yaml

@@ -34,6 +34,9 @@ parameters:
     type: boolean
     applyTo:
       - install
+  - name: sensitive
+    type: string
+    sensitive: true
 
 mixins:
   - exec