Support dependency outputs #525
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carolynvs
force-pushed
the
dep-outputs
branch
2 times, most recently
from
b369938
to
3fd7d35
Compare
carolynvs
changed the title
carolynvs
commented
Aug 20, 2019
| @@ -43,7 +43,7 @@ install: | |||
| #externalDatabase.database: "{{ bundle.dependencies.mysql.parameters.database-name }}" | |||
There was a problem hiding this comment.
I have another issue to address bundle.dependencies.DEP.parameters.PARAM #533
carolynvs
commented
Aug 20, 2019
| if err != nil { | ||
| return errors.Wrap(err, "unable to instantiate driver") | ||
| } | ||
| i := action.Uninstall{ | ||
| Driver: driver, | ||
| Driver: driver, | ||
| OperationConfig: args.ApplyFiles(), |
There was a problem hiding this comment.
This change here is part of a PR to cnab-go (see cnabio/cnab-go#112). In the meantime, we'll use my fork.
carolynvs
commented
Aug 20, 2019
pkg/config/runtime-manifest.go
Outdated
|
|
||
| if bun.Outputs == nil || m.Action == ActionUninstall { | ||
| // uninstalls are done backwards, so we don't have outputs available from dependencies | ||
| // TODO: validate that they weren't trying to use them at build time so they don't find out at uninstall time. |
carolynvs
commented
Aug 20, 2019
pkg/config/runtime-manifest.go
Outdated
| return nil, err | ||
| bun["dependencies"] = deps | ||
| for alias, bun := range m.bundles { | ||
| // TODO: Do we still want to allow resolving against bundle.dependencies.ALIAS.parameters.NAME and credentials? |
There was a problem hiding this comment.
We aren't going to support bundle.dependencies.DEP.credentials anymore. I will come back in another PR and remove that from the docs and examples.
carolynvs
force-pushed
the
dep-outputs
branch
2 times, most recently
from
481b2b3
to
b63d918
Compare
* Inject the output values for each dependency into /cnab/app/dependencies/SLUG/outputs * Inject the bundle.json for each dependency into /cnab/app/dependencies/SLUG/bundle.json * Inject bundle.dependencies.DEP.outputs.OUTPUT
|
Rebased |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/cnab/app/dependencies/ALIAS/outputs/cnab/app/dependencies/ALIAS/bundle.jsonbundle.dependencies.ALIAS.outputs.OUTPUTCloses #432