Split the exec arguments into flags and args #541
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carolynvs
force-pushed
the
exec-split-args-flags
branch
from
735bf80
to
f030f95
Compare
carolynvs
force-pushed
the
exec-split-args-flags
branch
from
f030f95
to
8458606
Compare
vdice
approved these changes
Aug 23, 2019
|
|
||
| "github.com/stretchr/testify/assert" | ||
| ) | ||
|
|
There was a problem hiding this comment.
Should we add a repeated flag test?
pkg/exec/flags.go
Outdated
| // flag1: value | ||
| // flag2: value | ||
| // flag3: | ||
| // - value1 |
There was a problem hiding this comment.
nit: this line and 110 seems to have a bit of extra spacing?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See the mixin doc for the new syntax https://deploy-preview-541--porter.netlify.com/mixins/exec/#mixin-syntax
Review this commit by commit, most of the files is me just tweaking existing usage of the mixin to be consistent with this change.