-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update skeletor to work with v1.0.0-alpha.22 #32
Conversation
carolynvs
commented
Jun 23, 2022
•
edited
Loading
edited
- Use v1.0.0-alpha.22 of Porter
- Switch from using the old magefile helper in Porter to using the new magefiles repository
- Add the TestPublish magefile target
- Rename get.porter.sh/porter/pkg/context to portercontext
- Change the skeletor go mod name so that it's easier for people to find/replace their way to a custom mixin. Using our vanity domain wasn't really helping anyone.
- Fix bad reference to packr, skeletor uses go:embed now.
* Use v1.0.0-alpha.22 of Porter * Switch from using the old magefile helper in Porter to using the new magefiles repository * Add the TestPublish magefile target * Rename get.porter.sh/porter/pkg/context to portercontext * Change the skeletor go mod name so that it's easier for people to find/replace their way to a custom mixin. Using our vanity domain wasn't really helping anyone. * Fix bad reference to packr, skeletor uses go:embed now. Signed-off-by: Carolyn Van Slyck <me@carolynvanslyck.com>
Signed-off-by: Carolyn Van Slyck <me@carolynvanslyck.com>
@@ -1,4 +1,4 @@ | |||
module get.porter.sh/mixin/skeletor | |||
module github.com/getporter/skeletor |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we have any plans for providing a skeletor for plugins? If we do, should we keep the prefix mixin
in the module name?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am naming it "plugin-template" for the plugins. I would like to rename skeletor to mixin-template to match. Skeletor is a reference to an old 80's cartoon (he man) and that wasn't a great idea for a project with users from around the world.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wow, after some googling, totally undrealted, turns our he man and she ra is in the same universe! I loved the she-ra remake!
I'm 100% onboard with the rename to template tho
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The new she-ra on netflix is great! 🌈 ✨
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I assume we want to do the rename in another PR
Yes, I will do the rename separately. 👍 |