Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update skeletor to work with v1.0.0-alpha.22 #32

Merged
merged 2 commits into from
Jul 8, 2022

Conversation

carolynvs
Copy link
Member

@carolynvs carolynvs commented Jun 23, 2022

  • Use v1.0.0-alpha.22 of Porter
  • Switch from using the old magefile helper in Porter to using the new magefiles repository
  • Add the TestPublish magefile target
  • Rename get.porter.sh/porter/pkg/context to portercontext
  • Change the skeletor go mod name so that it's easier for people to find/replace their way to a custom mixin. Using our vanity domain wasn't really helping anyone.
  • Fix bad reference to packr, skeletor uses go:embed now.

* Use v1.0.0-alpha.22 of Porter
* Switch from using the old magefile helper in Porter to using the new
  magefiles repository
* Add the TestPublish magefile target
* Rename get.porter.sh/porter/pkg/context to portercontext
* Change the skeletor go mod name so that it's easier for people to
  find/replace their way to a custom mixin. Using our vanity domain
  wasn't really helping anyone.
* Fix bad reference to packr, skeletor uses go:embed now.

Signed-off-by: Carolyn Van Slyck <me@carolynvanslyck.com>
Signed-off-by: Carolyn Van Slyck <me@carolynvanslyck.com>
@carolynvs carolynvs marked this pull request as ready for review June 27, 2022 17:03
@carolynvs carolynvs requested a review from VinozzZ June 27, 2022 17:04
@@ -1,4 +1,4 @@
module get.porter.sh/mixin/skeletor
module github.com/getporter/skeletor
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we have any plans for providing a skeletor for plugins? If we do, should we keep the prefix mixin in the module name?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am naming it "plugin-template" for the plugins. I would like to rename skeletor to mixin-template to match. Skeletor is a reference to an old 80's cartoon (he man) and that wasn't a great idea for a project with users from around the world.

Copy link

@VinozzZ VinozzZ Jul 8, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow, after some googling, totally undrealted, turns our he man and she ra is in the same universe! I loved the she-ra remake!
I'm 100% onboard with the rename to template tho

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The new she-ra on netflix is great! 🌈 ✨

Copy link

@VinozzZ VinozzZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume we want to do the rename in another PR

@carolynvs carolynvs merged commit ab7a7a0 into getporter:main Jul 8, 2022
@carolynvs
Copy link
Member Author

Yes, I will do the rename separately. 👍

@carolynvs carolynvs deleted the bump-porter branch July 8, 2022 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants