adding github workflow #38
Conversation
Signed-off-by: Sanskar Bhushan <sbdtu5498@gmail.com>
There was a problem hiding this comment.
Just a few nits and some clarifications needed from @schristoff
Thanks for this contribution.
| - name: Set up Go | ||
| uses: actions/setup-go@v2 | ||
| with: | ||
| go-version: 1.19.2 |
There was a problem hiding this comment.
We may want to change this to what is currently the latest. gov1.20.5
| - name: Cross Compile | ||
| run: mage XBuildAll | ||
|
|
||
| - name: Publish |
There was a problem hiding this comment.
Not sure we want to publish in this workflow.
Also being that this is a scaffold repository, it may be useful to just build/test and code coverage. There is a workflow we currently use for this in porter/operator that may fit here.
I'll defer to @schristoff with what we want as a workflow in this repository.
There was a problem hiding this comment.
Original issue seemed to want same capabilities of ADO pipeline for GH - I think it's more useful for users building the scaffolding then anything. I'd say keep it (for now), I'm open to removing if it becomes a hassle.
There was a problem hiding this comment.
@schristoff @troy0820 what changes should be done here? Let me know.
Fixes #30
cc: @schristoff @troy0820