-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mirror plugins during build #93
Conversation
Signed-off-by: Tamir Kamara <26870601+tamirkamara@users.noreply.github.com>
b0c4023
to
aec108e
Compare
@carolynvs I've tested this in a basic way but if easy enough I would have liked to take it into our harden environment and run it there. Is it possible to package the mixin as a file and then have |
@tamirkamara You can install the mixin from source with |
@carolynvs looks like it also works in our constraint environment. Can you please reivew? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tried this out with a test bundle and it seems there there is more configuration required to make this work. It didn't work for me and still downloaded the providers.
Is there more that needs to be done to make this work? Maybe some configuration file changes? If we are going to unconditionally mirror the providers, then the mixins should configure the bundle to automatically take advantage of those files.
@carolynvs can you explain how and where you saw it downloaded the providers? |
I was getting confused by this output:
It was taking a long time and I assumed it was installing the providers again. I just tried again with my network unplugged and confirmed that it is in fact using the mirrored providers. 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for making this feature work much better in airgapped scenarios!
Fixes #90.
When we build the bundle we can and should mirror the plugins terraform would use in runtime so that the bundle will be more self sufficient and won't need to access Terraform/Hashicorp endpoints to download things.