Update repo to use porter v1.0.0-rc.2 #97
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
VinozzZ
commented
Sep 16, 2022
•
VinozzZ
commented
- Update go module reference for Porter to 1.0.0-rc.2. Right now I'm pointing to release/v1, but will bump go.mod when it's available.
- Update code to match new version
- Use Go 1.18
- Print the terraform command run when in DebugMode
- Update mixin to support tracing. This doesn't instrument the mixin. It just updates the entrypoint so that it starts a root span and saves the resulting TraceLogger on the context so that later, we can use tracing.StartSpan or tracing.LoggerFromContext and get back an initialized logger.
- Bump default client version to 1.2.9. This updates the default client version installed when none is configured to the latest stable version of terraform.
- Update example bundles
Signed-off-by: Yingrong Zhao <yingrong.zhao@gmail.com>
Signed-off-by: Yingrong Zhao <yingrong.zhao@gmail.com>
Signed-off-by: Yingrong Zhao <yingrong.zhao@gmail.com>
Signed-off-by: Yingrong Zhao <yingrong.zhao@gmail.com>
Signed-off-by: Yingrong Zhao <yingrong.zhao@gmail.com>
carolynvs
reviewed
Sep 20, 2022
pkg/terraform/terraform.go
Outdated
| if m.Debug { | ||
| fmt.Fprintln(m.Err, "Terraform working directory is", m.Getwd()) | ||
| } | ||
| //if m.Debug { |
There was a problem hiding this comment.
Why was this commented out? Seems like the line just needed to be updated for DebugMode.
Signed-off-by: Yingrong Zhao <yingrong.zhao@gmail.com>
Signed-off-by: Yingrong Zhao <yingrong.zhao@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.