Skip to content

Commit

Permalink
Pin python3 image version (#5570)
Browse files Browse the repository at this point in the history
  • Loading branch information
@kravets-levko
kravets-levko authored Aug 18, 2021
1 parent 0f41f25 commit 380345b
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion Dockerfile
View file
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ COPY --chown=redash client /frontend/client
COPY --chown=redash webpack.config.js /frontend/
RUN if [ "x$skip_frontend_build" = "x" ] ; then yarn build; else mkdir -p /frontend/client/dist && touch /frontend/client/dist/multi_org.html && touch /frontend/client/dist/index.html; fi

FROM python:3.7-slim
FROM python:3.7-slim-buster

EXPOSE 5000

Expand Down

3 comments on commit 380345b

@ocZio
Copy link

@ocZio ocZio commented on 380345b Sep 6, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not really pinning a version of Python3 but rather the debian version (os).

If people install this within different timelines and there is a new version of Python 3.7.xx they will get different versions.

If you want to really pin it maybe try to specify the version? like 3.7.11-slim-buster

@susodapop
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good feedback. @kravets-levko can you take a look?

@kravets-levko
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This fix does exactly what it should. We needed to pin not the Python version, but its Docker image tag to use specific base Debian image. Maybe the explanation wasn't clear enough, so my apologies - I wanted to get it working ASAP 😄

Please sign in to comment.