address comments

getredash · Sep 24, 2022 · 66402ca · 66402ca
1 parent 3d8c86b
commit 66402ca
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 9 deletions.
diff --git a/redash/query_runner/pinot.py b/redash/query_runner/pinot.py
@@ -29,7 +29,6 @@
 
 class Pinot(BaseQueryRunner):
     noop_query = "SELECT 1"
-    controller_uri = "http://localhost:9000"
     username = None
     password = None
 
@@ -38,10 +37,10 @@ def configuration_schema(cls):
         return {
             "type": "object",
             "properties": {
-                "brokerHost": {"type": "string", "default": "localhost"},
+                "brokerHost": {"type": "string", "default": ""},
                 "brokerPort": {"type": "number", "default": 8099},
                 "brokerScheme": {"type": "string", "default": "http"},
-                "controllerURI": {"type": "string", "default": "http://localhost:9000"},
+                "controllerURI": {"type": "string", "default": ""},
                 "username": {"type": "string"},
                 "password": {"type": "string"},
             },
@@ -87,7 +86,7 @@ def run_query(self, query, user):
             data = {"columns": columns, "rows": rows}
             error = None
             json_data = json_dumps(data)
-            logger.debug("Pinot execute query [%s], and resp: %s", query, json_data)
+            logger.debug("Pinot execute query [%s]", query)
         finally:
             connection.close()
 
@@ -125,10 +124,10 @@ def get_metadata_from_controller(self, path):
         r = requests.get(url, headers={"Accept": "application/json"}, auth= HTTPBasicAuth(self.username, self.password))
         try:
             result = r.json()
-            logger.debug("get_metadata_from_controller from path %s: %s", path, result)
+            logger.debug("get_metadata_from_controller from path %s", path)
         except ValueError as e:
             raise pinotdb.exceptions.DatabaseError(
-                "Got invalid json response from " f"{self.controller_uri}:{path}: {r.text}"
+                f"Got invalid json response from {self.controller_uri}:{path}: {r.text}"
             ) from e
         return result
 

diff --git a/requirements_all_ds.txt b/requirements_all_ds.txt
@@ -45,6 +45,4 @@ pandas==1.3.4
 nzpy>=1.15
 nzalchemy
 python-arango==6.1.0
-pinotdb>=0.4.1
-httpx==0.23.0
-six==1.11.0
+pinotdb>=0.4.5