Fix embed pages

getredash · Dec 31, 2019 · 76461a8 · 76461a8
1 parent deaa1e2
commit 76461a8
Show file tree

Hide file tree

Showing 3 changed files with 11 additions and 7 deletions.
diff --git a/client/app/config/index.js b/client/app/config/index.js
@@ -98,13 +98,15 @@ function registerPages() {
     ngModule.config($routeProvider => {
       each(routes, (route, path) => {
         logger("Registering route: %s", path);
-        route.authenticated = true;
-        route.resolve = extend(
-          {
-            __organizationStatus: () => organizationStatus.refresh(),
-          },
-          route.resolve
-        );
+        route.authenticated = route.authenticated !== false; // could be set to `false` do disable auth
+        if (route.authenticated) {
+          route.resolve = extend(
+            {
+              __organizationStatus: () => organizationStatus.refresh(),
+            },
+            route.resolve
+          );
+        }
         $routeProvider.when(path, route);
       });
     });

diff --git a/client/app/pages/dashboards/PublicDashboardPage.jsx b/client/app/pages/dashboards/PublicDashboardPage.jsx
@@ -95,6 +95,7 @@ export default function init(ngModule) {
 
   return {
     "/public/dashboards/:token": {
+      authenticated: false,
       template: "<public-dashboard-page></public-dashboard-page>",
       reloadOnSearch: false,
       resolve: {

diff --git a/client/app/pages/queries/VisualizationEmbed.jsx b/client/app/pages/queries/VisualizationEmbed.jsx
@@ -221,6 +221,7 @@ export default function init(ngModule) {
 
   return {
     "/embed/query/:queryId/visualization/:visualizationId": {
+      authenticated: false,
       template: '<visualization-embed query="$resolve.query"></visualization-embed>',
       reloadOnSearch: false,
       resolve: {