Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Horizontal legend overlaps chart on small screens #3879

Closed
brylie opened this issue Jun 5, 2019 · 3 comments · Fixed by #3882
Closed

Horizontal legend overlaps chart on small screens #3879

brylie opened this issue Jun 5, 2019 · 3 comments · Fixed by #3882

Comments

@brylie
Copy link

brylie commented Jun 5, 2019

When viewing a chart with a small container width (<= 600px perhaps), the chart legend is configured to switch to horizontal mode. When the legend displays in horizontal mode, it can be seen to overlap the chart, particularly when there are several legend items:

Screenshot_20190605_145026

Steps to Reproduce

  1. Create a chart (e.g. editing it in the Visualization Editor)
  2. Ensure legend is visible
  3. resize the chart container to < 600 px (e.g. by resizing the browser screen or opening devtools)

I believe the legend should not overlap the chart, as it can hide information.

Technical details:

  • Redash Version: 6.x
  • Browser/OS: Kubuntu 19.04, Firefox 67
  • How did you install Redash: Git in development version
@kravets-levko
Copy link
Collaborator

I reproduced it only in FF, in Chrome/Chromium it works fine (Ubuntu 18.04). Space for legend is reserved under the plot, but legend has wrong position (not sure why).

@kravets-levko
Copy link
Collaborator

@brylie I submitted a fix for this issue (#3882) - can you please check if the bug has gone?

P.S. Tip: there is a deploy preview link below the PR.

@brylie
Copy link
Author

brylie commented Jun 12, 2019

Thanks @kravets-levko!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants