Add: query runner for Cassandra and ScyllaDB #1236
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -16,3 +16,4 @@ botocore==1.4.4 | |||
| sasl>=0.1.3 | |||
| thrift>=0.8.0 | |||
| thrift_sasl>=0.1.0 | |||
| cassandra-driver==3.1.1 | |||
There was a problem hiding this comment.
Is it pure Python or has some C/system package dependencies?
|
Looks great! Only few style things to fix. I also have some ideas on a few improvements -- like supporting multiple nodes in the host param or correctly setting the type of the column, but this can be left for another iteration. |
added 7 commits
August 16, 2016 15:59
|
@yershalom can I merge? |
|
@arikfr |
arikfr
changed the title
|
Merged. Thanks! |
Closed
simo7
pushed a commit
to pubnative/redash
that referenced
this pull request
Sep 22, 2016
Add: query runner for Cassandra and ScyllaDB
dairyo
pushed a commit
to KiiCorp/redash
that referenced
this pull request
Mar 1, 2019
Add: query runner for Cassandra and ScyllaDB
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.