-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docker based developer workflow #1530
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
For those following: I removed Webpack from Docker Compose: I realized that it makes more sense to run Webpack on the host machine as usually you will need to install Node.js's tools on the host to enjoy better intelisense and eslint support in the editor. On top of that, installing Node.js on most developer machines should be relatively easy. |
I realized that it makes more sense to run Webpack on the host machine as usually you will need to install Node's tools on the host to enjoy better intelisense and eslint support in the editor. On top of that, installing Node.js on most developer machines should be relatively easy.
arikfr
force-pushed
the
docker_workflow
branch
from
January 19, 2017 13:21
3c89643
to
4e4d52a
Compare
arikfr
changed the title
[WIP] Docker based developer workflow
Docker based developer workflow
Jan 22, 2017
Updated dev guide: getredash/website#35 |
This was referenced Jan 26, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This replaces our Vagrant workflow. I am still testing this and working on documentation, but looks like it works nicely.
Added dedicated Docker Compose file (docker-compose.yml) and refactored our Docker image.
Usage:
To create the database:
Then open http://localhost:8080 and start working. The dev server will restart on code changes, but you will need to restart the worker manually (
docker-compose restart worker
).TODO:
Closes #900, #1377, #628, #1050.