Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docker based developer workflow #1530

Merged
merged 15 commits into from
Jan 22, 2017
Merged

Docker based developer workflow #1530

merged 15 commits into from
Jan 22, 2017

Conversation

arikfr
Copy link
Member

@arikfr arikfr commented Jan 16, 2017

This replaces our Vagrant workflow. I am still testing this and working on documentation, but looks like it works nicely.

Added dedicated Docker Compose file (docker-compose.yml) and refactored our Docker image.

Usage:

# Shell 1:
docker-compose up

# Shell 2:
npm run start

To create the database:

docker-compose run --rm server create_db

Then open http://localhost:8080 and start working. The dev server will restart on code changes, but you will need to restart the worker manually (docker-compose restart worker).

TODO:

  • Updated instructions on how to create the DB.
  • Updated instructions in docs repo (both docker setup & dev guide).

Closes #900, #1377, #628, #1050.

@arikfr arikfr mentioned this pull request Jan 16, 2017
@arikfr
Copy link
Member Author

arikfr commented Jan 18, 2017

For those following:

I removed Webpack from Docker Compose:

I realized that it makes more sense to run Webpack on the host machine as usually you will need to install Node.js's tools on the host to enjoy better intelisense and eslint support in the editor.

On top of that, installing Node.js on most developer machines should be relatively easy.

@arikfr
Copy link
Member Author

arikfr commented Jan 19, 2017

Added setup wizard for first run of Redash to create the admin user & name the organization (no more "X invited you to join the Redash account of Default").

image

@arikfr arikfr changed the title [WIP] Docker based developer workflow Docker based developer workflow Jan 22, 2017
@arikfr arikfr merged commit b479bb3 into master Jan 22, 2017
@arikfr
Copy link
Member Author

arikfr commented Jan 22, 2017

Updated dev guide: getredash/website#35
(soon to be merged)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants