React alert-subscriptions component #2634
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks ! Can you add a screenshot, so we can see how react-select looks like? |
|
|
|
(Note that the eslint errors here are because it's not using the React eslint support in #2632 ) |
washort
force-pushed
the
react-alert-subscriptions
branch
from
90db672 to
0d3859d
Compare
openjck
reviewed
Jun 28, 2018
washort
force-pushed
the
react-alert-subscriptions
branch
from
0d3859d to
886107d
Compare
washort
force-pushed
the
react-alert-subscriptions
branch
from
886107d to
dcbefe3
Compare
|
This pull request is automatically deployed with Now. To access deployments, click Details below or on the icon next to each push. |
arikfr
requested changes
Oct 3, 2018
washort
force-pushed
the
react-alert-subscriptions
branch
2 times, most recently
from
1be6fcb to
64c5e01
Compare
|
This now uses Ant and is up to date with master. |
spasovski
reviewed
Dec 7, 2018
spasovski
reviewed
Dec 7, 2018
spasovski
reviewed
Dec 7, 2018
spasovski
reviewed
Dec 7, 2018
spasovski
reviewed
Dec 7, 2018
spasovski
reviewed
Dec 7, 2018
spasovski
reviewed
Dec 7, 2018
|
Code looks good apart from my one onChange question. Let me know if you need a second look later. |
washort
force-pushed
the
react-alert-subscriptions
branch
from
64c5e01 to
626fe9e
Compare
ghost
assigned 
|
Replaced by #4081. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was one of the first major pieces I converted, since it was somewhat standalone and needed some complex behavior. Good example of how to use customized selection UI and handle Angular DI.