Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: add API hook for schema browser display #2826

Closed
wants to merge 1 commit into from

Conversation

alison985
Copy link
Contributor

Original issue: mozilla#185
Original PR: mozilla#201

Issue to post this upstream: mozilla#430
Previous PR code reviews trying to port this upstream: #2655 #2764

Problem: This javascript forEach loop breaks the autoComplete feature/typing in the query textarea. Additional/random keys appear in it when typing. If you comment out this forEach loop the problem disappears. I have tried writing the loop different ways and this is the only one that really passes the linter. I have no idea why this interaction is occurring and would love any help or pointers in the right direction.

This PR:

  • Adds the key font awesome icon to partition keys in the schema browser for Presto and Athena data sources.
  • Adds a hook and API response to tell the front-end javascript which schema browser to use.
  • Supports partition keys in the Athena Glue catalog generated schema.

@vercel
Copy link

vercel bot commented Sep 17, 2018

This pull request is automatically deployed with Now.
To access deployments, click Details below or on the icon next to each push.

@alison985
Copy link
Contributor Author

@jezdez Reminder ping on the javascript question.

@arikfr
Copy link
Member

arikfr commented Oct 4, 2018

I don't remember the name right now, but there is a function in Lodash that does exactly this (returns only the properties you defined from a Javascript object).

While having support for different schema browser components makes sense, I don't think this is the case for it. To implement what's needed here it's enough to:

  1. Extend the default schema browser to support showing icons next to the column names.
  2. Extend the schema data structure to support having an icon metadata along with the column name.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants