Charts lose responsive features after refreshing the dashboard #3024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9 tasks
|
The size of the chart is known when we render it, why doesn't the layout get correct sizes/positioning from the get go? |
|
@arikfr because to align legend, we also need to know it's size, which is unavailable until chart is rendered |
axeltlarsson
added a commit
to Jojnts/redash
that referenced
this pull request
Jan 28, 2019
Squashed commit of the following:
commit 4780bd9c5ef212dd4c38bafb525abc991812d59b
Merge: 3ee7537a ef66da7d
Author: Arik Fraimovich <arik@arikfr.com>
Date: Sun Dec 16 20:27:43 2018 +0200
Merge pull request #3196 from getredash/master
Sync release/6.0.x branch with master
commit ef66da7d94c1c9ff7d4adb924f09047a49899a62
Author: Arik Fraimovich <arik@arikfr.com>
Date: Sun Dec 16 16:01:20 2018 +0200
V6 release (#3195)
* V6 release
* Remove "-beta"
* Update package.json
* Update package-lock.json
* Update CHANGELOG.md
commit 57c8fbe14e91c7091a5b89186a5cd17e4971e991
Author: Arik Fraimovich <arik@arikfr.com>
Date: Sun Dec 16 09:55:34 2018 +0200
README updates
1. Remove link to Slack channel.
2. Update number of data sources.
commit 938a20e7c05a2c3d55fa6805dc5830b318e30e27
Author: Arik Fraimovich <arik@arikfr.com>
Date: Sun Dec 16 09:42:32 2018 +0200
Use multiple issue templates instead of a single one (#3194)
* Switch to issue templates
* Apply a label to non bugs
commit f5dbdf245a705d7813e6ff56575660616a1f05c9
Author: Arik Fraimovich <arik@arikfr.com>
Date: Thu Dec 13 15:10:31 2018 +0200
Safely create_app in Celery code (try to fetch current_app first). (#3187)
Closes #3181.
commit 8481dacff43b767ccc129ea068a09d888c130db2
Author: Gabriel Dutra <nesk.frz@gmail.com>
Date: Wed Dec 12 19:32:12 2018 -0200
Fix eslint issues on user.js (#3186)
commit e23a07af03939e943e95c75b904963dcfd711557
Author: Omer Lachish <omer@rauchy.net>
Date: Wed Dec 12 08:30:46 2018 +0200
Remove missing coverage from pytest terminal output (#3180)
* Remove missing coverage from pytest terminal output
* move coverage reporting to CI
commit 52434a837f668fefa3673cd17f59cd8aae3d603a
Author: Arik Fraimovich <arik@arikfr.com>
Date: Tue Dec 11 15:03:29 2018 +0200
Make refresh_queries less noisey in logs (#3183)
commit 230ad33f02a331175aefffd8f13f4c4f1371a0bc
Author: Arik Fraimovich <arik@arikfr.com>
Date: Tue Dec 11 14:57:42 2018 +0200
[Redshift] Fix: support for schema names with dots. (#3182)
commit cfe12c5a5d37b8ec01c8a26fd9c8c8ad97e12d07
Author: Gabriel Dutra <nesk.frz@gmail.com>
Date: Mon Dec 10 18:29:36 2018 -0200
Add DB Seed to Cypress and setup Percy (#3155)
* Update Cypress element selectors
* Add seed data function to Cypress
* Change Cypress setup to be part of db-seed
* Add DatabaseSource selector to Create Data Source spec
* Add getElement command to Cypress
* Fix eslint issues
* Change Cypress getElement to getByTestId
* Add Percy and test it with the CI
* Change Percy dependency for CI to Cypress' Dockerfile
* Change Percy's execution to the docker container
- add --no-save to avoid errors on Dockerfile.cypress
- pass PERCY_TOKEN from the CI to docker container
* Fix missed char on CircleCI config file
* Move Percy execution back to host on the CI
* Test adding PERCY_TOKEN to frontend-e2e-tests on CI config
* Undo add PERCY_TOKEN to config.yml
* Add Percy token and .git folder to Cypress
* Remove Percy install from config.yml
* Ignore .git folder again and use Percy env vars instead
* Update PERCY_PULL_REQUEST to be CIRCLE_PR_NUMBER
* Update cypress-server.js to handle other cypress commands
- cypress-server.js -> cypress.js
- new commands added to cypress.js
- CircleCI config updated accordingly
- added a Homepage screenshot
* Remove trailing spaces
* Add Create Query spec
* Disable Cypress videos
* Update run browser to Chrome
* Add missing --browser chrome
commit 38ed046c9fae428e17d9af9e8a7c51f3d6df3983
Author: Omer Lachish <omer@rauchy.net>
Date: Mon Dec 10 14:02:50 2018 +0200
Fix disable error message (#3175)
* display correct error message when attempting to disable yourself
* 403 (Forbidden) feels like a better status code than 400 (Bad Request)
* fix broken test
* remove redundant error title
commit 1acf063755ca5caabf01a28cd482f28562b28f3b
Author: Takuya Arita <takuya.arita@gmail.com>
Date: Mon Dec 10 19:35:25 2018 +0900
FIX: Reject empty query name (#3171)
commit 76321937d766e650a1f6bdf61b0a6575c9f063fc
Author: Omer Lachish <omer@rauchy.net>
Date: Wed Dec 5 12:21:18 2018 +0200
Remove API permissions for users who have been disabled (#3162)
commit c9ca2b99f6e266a8af92a4addeb532737e2b17e9
Author: Arik Fraimovich <arik@arikfr.com>
Date: Wed Dec 5 11:28:05 2018 +0200
Fix: Alert.evaluate failing when the column is missing. (#3167)
commit d42f0b2d40a2b7686b20d8a8c59a8eb21e87c821
Author: Arik Fraimovich <arik@arikfr.com>
Date: Wed Dec 5 10:11:08 2018 +0200
Directly using record_event task requires timestamp (#3166)
Using the helper instead.
commit e530c23d4cfee361483db590b52a1f0afdf3cf50
Author: Vladislav Denisov <denisov@sports.ru>
Date: Wed Dec 5 10:29:47 2018 +0300
clickhouse: fixed int() conversion error (#3161)
commit 0973ee8abbeea3cf74ca082fdc3c9acfeb4beb85
Author: Omer Lachish <omer@rauchy.net>
Date: Tue Dec 4 22:14:32 2018 +0200
Include correct version in production builds (#3163)
* take the first 8 characters for frontend version, not backend version
* run `npm run build` after version has been updated in CI
* `pack` should run last
commit 3ee7537a6c049a98e7284c67b98130556031e263
Author: Arik Fraimovich <arik@arikfr.com>
Date: Mon Dec 3 22:07:20 2018 +0200
WIP: Update CHANGELOG (#3159)
commit 9c12b045787f2f87106ffab046291a015cdb1d31
Author: Arik Fraimovich <arik@arikfr.com>
Date: Mon Dec 3 10:57:36 2018 +0200
json_dumps: add support for serializing buffer objects. (#3156)
commit 9579f12a83becf778a692acf185fc34ebb3efe1c
Author: Omer Lachish <omer@rauchy.net>
Date: Sun Dec 2 21:51:06 2018 +0200
Protect against SQL injections by using tree comparisons (#3109)
* add SQLQuery class with tests for safe queries and non-safe tautology attacks
* add test for union query injections
* split .apply calls to newline
* add tests for comment attacks
* remove double underscore
* extract complex children check to variable
* inherit from object because I'm not a lamer
Co-Authored-By: rauchy <omer@rauchy.net>
* simplify cognitive complexity
* check that additional columns are not injected
* detect appended queries
* inline .apply calls
* move SQLQuery to it's own module
* move SQLQuery tests to their own module
* serialize SQLQuery instances
* raise an exception when attempting to serialize an unsafe query
* queries without parameters are safe
* remove redundant parentheses
* use cached properties
* rename SQLInjectionException to SQLInjectionError
* support multiple word params and param negations
* refactor out methods that don't involve any state
* don't cache text()
* reduce cognitive complexity
commit 463d4ce518292de0bec436b9bfb2d1e68ab077fd
Author: Zsolt Kocsmárszky <kocsmy@gmail.com>
Date: Sun Dec 2 09:42:30 2018 +0100
Fix label positioning on no found screen (#3148)
* Fix label positioning on no found screen
* Use TagsControl component on not found screen
commit 2e4d1964521ede72b224ce06ac0c0edbc006524a
Author: Zsolt Kocsmárszky <kocsmy@gmail.com>
Date: Sun Dec 2 09:27:01 2018 +0100
Add and improve recent db logos that didn't fit in size properly (#3147)
* Add and improve recent db logos that didn't fit in size properly
* Update mongodb logo
* Remove Athena Direct as requested
commit 4078af299637b7cffa04d2dda6ef565f48a5059c
Author: Zsolt Kocsmárszky <kocsmy@gmail.com>
Date: Thu Nov 29 20:04:35 2018 +0100
Update, replace and fix new alert destination logos so it fits better (#3146)
commit 73825ea266945fcf52516f2c0f4d43b534bc2e8c
Author: Zsolt Kocsmárszky <kocsmy@gmail.com>
Date: Thu Nov 29 20:02:54 2018 +0100
Improve tag link colors and fix group tags on Users page (#3149)
commit b2a0d618441519ae0d88c69d2a4a7759d7b4c424
Author: Zsolt Kocsmárszky <kocsmy@gmail.com>
Date: Thu Nov 29 14:40:44 2018 +0100
Better manage permissions modal (#3139)
* Improved design for manage permissions
* Show Owner on Permission modal, remove owner from dropdown options
* Pass owner to Permissions modal
commit 1774edabc0a8f6234f4239636f31ecf674392ea5
Author: Omer Lachish <omer@rauchy.net>
Date: Thu Nov 29 15:20:30 2018 +0200
take the first 8 characters for frontend version, not backend version (#3145)
commit 54b8e7c13622f2a9b8d3b9214f7aa117b37526e3
Merge: 757333c2 54f09f73
Author: Omer Lachish <omer@rauchy.net>
Date: Thu Nov 29 15:17:14 2018 +0200
Merge pull request #3144 from getredash/display-frontend-version
Display only the first 8 characters of frontend version
commit 54f09f73dbf403df5614691b32fb76ffc62d42ff
Author: Omer Lachish <omer@rauchy.net>
Date: Thu Nov 29 15:03:37 2018 +0200
take the first 8 characters for frontend version
commit 35aca1d4cf4d03bdd8de3f6b8209d64f5876bf3b
Merge: 407f14ff 757333c2
Author: Omer Lachish <omer@rauchy.net>
Date: Thu Nov 29 15:03:11 2018 +0200
Merge branch 'master' into display-frontend-version
commit 757333c2d610dc7867dc7f5849558026063cd659
Author: Levko Kravets <levko.ne@gmail.com>
Date: Thu Nov 29 14:48:21 2018 +0200
When editing a dashboard title results in the visualizations being replaced by the loading markers (#3142)
* getredash/redash#3015 When editing a dashboard title results in the visualizations being replaced by the loading markers
* CR1
Co-Authored-By: kravets-levko <levko.ne@gmail.com>
commit 92728de04caad09c2c35ec54cd297a8abe619743
Author: Omer Lachish <omer@rauchy.net>
Date: Thu Nov 29 14:24:23 2018 +0200
Display frontend version (#3105)
* add git-revision-webpack-plugin
* configure git-revision-webpack-plugin
* add commit to footer
* rename version and commit to backendVersion and frontendVersion
* rename version and commit to backendVersion and frontendVersion
* disable lint error due to use of globals
* fix snapshot test
* read frontend version from VERSION file instead latest git revision
* directly require from version.json file instead of going through WebPack's DefinePlugin
* run snapshots
commit 407f14ffcac85575917ceeeaae5c006045d2d800
Author: Omer Lachish <omer@rauchy.net>
Date: Thu Nov 29 13:07:04 2018 +0200
run snapshots
commit ecb8a5c244db1df100eb1e0dbc8c5bcfcf0f2644
Author: Arik Fraimovich <arik@arikfr.com>
Date: Thu Nov 29 13:01:23 2018 +0200
Hive/Databricks related improvements (#3143)
* Hive: fix issues in building options.
* Hive: add missing import.
* Split Hive into two query runners: one for http and a regular one.
* Upgrade pyhive to support http.
* Specific implementation for databricks:
* Different schema loader, because column names are different (or Hive's schema loader is broken).
* Simpler configuration.
* Simplify Databricks setup even more by removing username.
commit 0e8fab48724d6666db4b4f5499256ad22414ca9e
Author: Omer Lachish <omer@rauchy.net>
Date: Thu Nov 29 13:00:13 2018 +0200
directly require from version.json file instead of going through WebPack's DefinePlugin
commit c15fa0c592d665812cee176b057f882aedee9bf7
Author: Omer Lachish <omer@rauchy.net>
Date: Thu Nov 29 11:57:53 2018 +0200
read frontend version from VERSION file instead latest git revision
commit 09ab00e360b811ff277f8d7732761cb5b83344a4
Author: Levko Kravets <levko.ne@gmail.com>
Date: Thu Nov 29 11:35:17 2018 +0200
Migrate all tags components to React (#3138)
commit 1728f924cfb1c49d3ae63073d781003337111167
Author: Truong Hoang Phuoc, Robert <hoangphuoc25@gmail.com>
Date: Thu Nov 29 15:19:36 2018 +0800
Fix schema refresh to work on MySQL 8 (#3141)
commit 8dc10fbd9a051647e0a9547478414d7c67a35fb8
Merge: 8028397f a16170e7
Author: Omer Lachish <omer@rauchy.net>
Date: Thu Nov 29 09:13:41 2018 +0200
Merge branch 'master' into display-frontend-version
commit a16170e7014ecb773b748963497f7ddcc7dec43d
Author: Jannis Leidel <jannis@leidel.info>
Date: Wed Nov 28 13:06:15 2018 +0100
Fix tag counts for dashboards and queries. (#3120)
* Fix tag counts for dashboards to be distinct.
This also makes use of the Dashboard.all base query.
Fix #3108.
* Use Query.all_queries as the base query for Query.all_tags.
* Add test case for Dashboard.all_tags.
commit 07c0bba56849dfa902a9785cf1b1c16b59dc2ec4
Author: Arik Fraimovich <arik@arikfr.com>
Date: Wed Nov 28 10:36:33 2018 +0200
Delete now.json (#3134)
commit d36d18f85b5556071f7812574dd19f4c0b8546a0
Author: Arik Fraimovich <arik@arikfr.com>
Date: Tue Nov 27 09:06:44 2018 +0200
Support unicode in Postgres/Redshift schema (#3124)
commit bd20ce12ac94d21b425fff55cc6c906395ca8c48
Author: Arik Fraimovich <arik@arikfr.com>
Date: Mon Nov 26 21:22:14 2018 +0200
Don't allow updating user's email to blacklisted domain. (#3127)
commit 1cdfcfaa3cfcc1427d803e7c72e550ec8fbd00dd
Author: Arik Fraimovich <arik@arikfr.com>
Date: Mon Nov 26 21:21:49 2018 +0200
Vertica: update driver & add support for connection timeout (#3125)
* Update Vertica driver version
* Vertica: add support for connection timeout
commit 2fdace518a7ceacbfd2f6f1c29318f222e51d3b4
Author: Arik Fraimovich <arik@arikfr.com>
Date: Mon Nov 26 21:21:07 2018 +0200
Use lower timeout for the first 5 seconds when polling for results. (#3128)
commit 3516e4ef45c74bb44c24d27a452aa45deb504796
Author: Igor Canadi <igor.canadi@gmail.com>
Date: Mon Nov 26 11:20:37 2018 -0800
Add Rockset query runner (#3068)
* Add Rockset query runner
Per REST API documented here: https://docs.rockset.com/rest/
* Update rockset.py
* Add Rockset logo
* Refactor Rockset qury runner:
* More idomatic names for configuration.
* Move API code to separate class to make it easier removing it when we
switch to official library.
* Make Test Connection work.
* apply autopep8 to rockset.py
commit d84296814200a8f5d444801aa2cc70f5535d59cd
Author: Arik Fraimovich <arik@arikfr.com>
Date: Mon Nov 26 16:08:04 2018 +0200
MongoDB: add support for sorting columns. (#3126)
commit 600741620a6889915327357847e2350be2037776
Author: Arik Fraimovich <arik@arikfr.com>
Date: Mon Nov 26 15:31:39 2018 +0200
Remove (Beta) from Query Results query runner name (#3123)
commit 45f4277eb4f0a3db01f5f286c876a3917f5bb2f9
Author: YOSHIDA Katsuhiko <claddvd@gmail.com>
Date: Mon Nov 26 21:23:55 2018 +0900
Fix forked query is opened in the same tab (#3121)
commit bcf3041c91da6f15397aaccd80654986ffe5b1b4
Author: Jannis Leidel <jannis@leidel.info>
Date: Mon Nov 26 13:02:52 2018 +0100
Show menu divider only if query is archived. (#3122)
Fix #3117.
commit da423340ecba15532f82aec7d929c7f921ccf553
Author: Zsolt Kocsmárszky <kocsmy@gmail.com>
Date: Mon Nov 26 12:41:07 2018 +0100
Fix mobile padding issues on Query results (#3111)
commit 4003d4f1aa9a8ffd19ccdd0fb937eaa0238a81f3
Author: Arik Fraimovich <arik@arikfr.com>
Date: Mon Nov 26 09:58:39 2018 +0200
Add event tracking to autocomplete toggle & trackEvent helper function (#3114)
* Add non Angular version of Events.
* Add event tracking for autocomplete toggle
* Fix lint error in QueryEditor
commit a6b782e0ce1422db51ea023e6f6d5cd64b774a66
Author: YOSHIDA Katsuhiko <claddvd@gmail.com>
Date: Sun Nov 25 21:11:27 2018 +0900
Add get_current_user() into Python Data Source (#3088)
commit 5648de9ba8abb9b7c8596697d1a2dc17f8d59fe9
Author: YOSHIDA Katsuhiko <claddvd@gmail.com>
Date: Sun Nov 25 21:09:52 2018 +0900
Open new tab when forking a query (#3089)
* Open new tab when forking a query
* Delete old fork menu item and add icon
commit 13eb365f7b72776cb0a954ac0436c1b9bf7fa54e
Author: Jannis Leidel <jannis@leidel.info>
Date: Sun Nov 25 13:08:25 2018 +0100
Update changelog for v6.0.0-beta. (#3112)
* Add v6.0.0-beta changelog entry.
* Update CHANGELOG.md
commit 8257d9d0371ae579eec7577946f6234ae0eda227
Author: Udomomo <batzuma@yahoo.co.jp>
Date: Sun Nov 25 20:47:25 2018 +0900
Add permissions to the result of "manage.py groups list" command (#3007)
* Add permissions to the result of "groups list" command
* added permissions to test case
* removed setting for debug
commit babbeb79f0c9d7f8fe5a9f4e6b51c740b23e1e38
Author: Allen Short <ashort@mozilla.com>
Date: Fri Nov 23 13:28:30 2018 +0000
keep query text in local state for now (#3107) (#3110)
* keep query text in local state for now (#3107)
This will be unnecessary once the queryText prop isn't managed by Angular.
* Fix: make formatQuery work
commit 8028397f274b25bd8ada025d4a6a67b91997407f
Merge: fae2b708 e05c8e60
Author: Omer Lachish <omer@rauchy.net>
Date: Thu Nov 22 12:52:43 2018 +0200
Merge branch 'master' into display-frontend-version
commit e05c8e6060c2a185e951b2ecd5ff53ca8aec2673
Author: Subhi Al Hasan <jodevsa@gmail.com>
Date: Wed Nov 21 17:13:12 2018 +0200
Fix collection fields retreival bug when Views are present in MONGO DB (#3097)
* Fix collection fields retreival bug when Views are present in MongoDB
* fixing _is_collection_a_view function
* Update redash/query_runner/mongodb.py
Co-Authored-By: jodevsa <jodevsa@gmail.com>
commit fae2b708662389eb2b0a8fe928269ad16220c887
Merge: 1119fce4 1b66fff3
Author: Omer Lachish <omer@rauchy.net>
Date: Wed Nov 21 10:49:29 2018 +0200
Merge branch 'display-frontend-version' of github.com:getredash/redash into display-frontend-version
commit 1119fce44c67534f50d43be9ae9c2edc180ecf35
Merge: bfb7edc0 0fe1b5f9
Author: Omer Lachish <omer@rauchy.net>
Date: Wed Nov 21 10:48:03 2018 +0200
Merge branch 'master' into display-frontend-version
commit bfb7edc0eb2b4b4f628c3e8390800804559d5192
Author: Omer Lachish <omer@rauchy.net>
Date: Wed Nov 21 10:47:54 2018 +0200
fix snapshot test
commit a39a7394736551193825ad34a813464d1581a3b2
Author: Omer Lachish <omer@rauchy.net>
Date: Wed Nov 21 10:44:34 2018 +0200
disable lint error due to use of globals
commit c9dfac5b1d979319ee7c8f968ac010fb4d8a8664
Author: Omer Lachish <omer@rauchy.net>
Date: Tue Nov 20 23:34:39 2018 +0200
rename version and commit to backendVersion and frontendVersion
commit 1b66fff3be618da345f905c1f2a7bc4c40146bed
Author: Omer Lachish <omer@rauchy.net>
Date: Tue Nov 20 23:34:39 2018 +0200
rename version and commit to backendVersion and frontendVersion
commit 0fe1b5f9d439c4d9b76c592ad4c17f4e4c51d86e
Author: Arik Fraimovich <arik@arikfr.com>
Date: Tue Nov 20 23:34:37 2018 +0200
Fix: registerAll fails after minification (#3106)
commit 143db90a509bbe0c80b8e55ce76fbb572679ab81
Author: Levko Kravets <levko.ne@gmail.com>
Date: Tue Nov 20 18:48:41 2018 +0200
Fix query page header (#3046)
* getredash/redash#3017 Improve query page header
* getredash/redash#3017 Resolve conflicts
* getredash/redash#3017 CR1 (fix margins/paddings)
commit bac90db3ee7a099fd3a3a3350f193dbfed364b01
Author: Arik Fraimovich <arik@arikfr.com>
Date: Tue Nov 20 18:45:33 2018 +0200
Autocomplete toggle improvements (#3091)
* Autocomplete toggle improvements:
* Refactor to its own component.
* Show state in tooltip (enabled/disabled).
* Disable the toggle if autocomplete is not possible (no schema/too many tokens).
* Remove unsued code.
* Custom icons font (currently has only two icons).
Generated with Icomoon. If we extend its use, we should probably automate this and move to its own package.
* Don't disable live autocomplete for data sources without schema.
It can still be useful to autocomplete from local keywords.
* Differentiate between autocomplete toggle states with an icon.
Also added explicit message for the disabled state.
* Remember thes state of autocomplete.
* Only auto register init functions.
commit 649d46de89c15252b65a50a91f5e3c4315a52ab1
Author: Omer Lachish <omer@rauchy.net>
Date: Tue Nov 20 15:25:07 2018 +0200
add commit to footer
commit 0163e85eda0d66ec13ccaf5b917167a7e713a469
Author: Omer Lachish <omer@rauchy.net>
Date: Tue Nov 20 15:24:55 2018 +0200
configure git-revision-webpack-plugin
commit f25beb3fb776c9cf2f458be1a08ab65c5f6e2670
Author: Omer Lachish <omer@rauchy.net>
Date: Tue Nov 20 15:24:41 2018 +0200
add git-revision-webpack-plugin
commit c66f63d7a5e152202e9c0faa98dcec0c4b8ea6df
Author: Omer Lachish <omer@rauchy.net>
Date: Tue Nov 20 12:22:15 2018 +0200
Prevent Query's updated_at from changing when it is linked to new query results (#3082)
* avoid Query's updated_at from changing when it is linked to new query results
* move comment to previous line
* move QueryResult tests to their own module
* add test which verifies that updated_at is not changed on query data
updates
* tests were false positives - they compared HH:MM:SS, but that never
changed because the original time was 1 week behind.
* remove redundant constructor
* remove hack and use a proper event to prevent updated_at from changing
* use self.assertEqual instead of assert
commit 16ae0aa3d8a30a75e1cb72daaa0ed8691e46c4dd
Author: Levko Kravets <levko.ne@gmail.com>
Date: Tue Nov 20 11:06:09 2018 +0200
getredash/redash#2901 Fix docs links (#3102)
commit 68ada7b590ce359f6fccc8a548ebca33b62d936b
Author: Arik Fraimovich <arik@arikfr.com>
Date: Tue Nov 20 10:04:42 2018 +0200
UI for the feature flag of the share edit permissions feature (#3077)
* Remove unused settings.
* Add: UI feature flag for sharing permissions
* Revise feature flag message
commit 9e745ef6489f396da2f8d7aaf85abfe6567e769b
Author: San <zhujunsan@gmail.com>
Date: Tue Nov 20 15:48:24 2018 +0800
Delete redundant regex segment (#3100)
commit ee0d7f5ec9efd03dcd3415980ca2eade81fbab38
Author: Allen Short <ashort@mozilla.com>
Date: Tue Nov 20 06:06:32 2018 +0000
force angular to update query editor properly (re #3098) (#3099)
commit e36853ca84e6d8431a06899c8aab455ad6c15bcc
Author: Levko Kravets <levko.ne@gmail.com>
Date: Mon Nov 19 12:33:05 2018 +0200
Tags autocomplete: some tags not shown on search (#3094)
* getredash/redash#3052 Tags autocomplete: some tags not shown on search
* getredash/redash#3052 CR1
commit d43b35ba6f9e3b8ee013062cc25ce6c9c165ea25
Author: YOSHIDA Katsuhiko <claddvd@gmail.com>
Date: Sun Nov 18 18:21:00 2018 +0900
Change Standard SQL as the default (#3085)
commit 6e4f0ccee8513cdba70a7a97cf5f51ff0c80d5cf
Author: Topher Cyll <christophercyll@gmail.com>
Date: Sun Nov 18 04:05:18 2018 -0500
Bubble chart marker size override was clobbering seriesColor. (#3063)
Colors can now be set for bubble charts in UI.
commit 0ce7772aa356daebc9fc80f72e95dbb53f03fa9c
Author: Vladislav Denisov <denisov@sports.ru>
Date: Thu Nov 15 23:11:43 2018 +0300
clickhouse: added WITH TOTALS option support (#3083)
commit f6ef38479c915d5cfd967c4e7f200044f76a5a3c
Author: San <zhujunsan@gmail.com>
Date: Fri Nov 16 04:08:02 2018 +0800
support tel, sms, mailto links in the query result (#3084)
commit bf85ddaaffa125a7474d87690f5a2cd97be1613b
Author: Arik Fraimovich <arik@arikfr.com>
Date: Thu Nov 15 08:58:30 2018 +0200
Always use basic autocomplete. (#3079)
commit 8bb96c8c9170b016473745f41466cf706405588e
Author: Arik Fraimovich <arik@arikfr.com>
Date: Wed Nov 14 15:43:34 2018 +0200
Fix: URL data source shouldn't require URL. (#3078)
Closes #2919.
commit 42b05cee00dab3b73e6275bf50df91796a8968eb
Author: Filipe Veloso <Rovel@users.noreply.github.com>
Date: Wed Nov 14 10:27:19 2018 -0200
Update docker-compose.yml (#2905)
* Update docker-compose.yml
jut updating docker-compose dev to version 3, any special reason to keep redis on 3? and pg on 9.5? I could also add a volume to pg, any reason not to do so?
* rollback to redis 3 and pg 9.5 due to consistency in project defaults
* Configure volume directly in worker service.
commit d0fd02123a3ca1a8112f666b4206e40cfadf5598
Author: Anton Burnashev <anton.burnashev@gmail.com>
Date: Wed Nov 14 09:44:38 2018 +0100
Add white-space padding to separators in the footer (#3076) (#3076)
Closes #3075
commit e34203dac3f1977cbf219bc0b29119d0db01ce9d
Author: Takuya Arita <takuya.arita@gmail.com>
Date: Tue Nov 13 23:45:40 2018 +0900
Remove only Redash containers (#3073)
commit c2bd8518a68c87679a0834d678f08c4a13be1bbd
Author: koooge <koooooge@gmail.com>
Date: Mon Nov 12 17:06:25 2018 +0900
Makefile: Add make targets for test (#3032)
commit 46363ccc70152efae0ac8a650eca19450476d0c5
Author: Levko Kravets <levko.ne@gmail.com>
Date: Mon Nov 12 08:50:44 2018 +0200
Table visualization horizontal scrollbar should not be always visible (#3061)
commit 5e1512e777ec2fe056f227920b0748808f6a632b
Author: Levko Kravets <levko.ne@gmail.com>
Date: Thu Nov 8 22:54:08 2018 +0200
Mustache: don't html-escape query parameters values (#3058)
commit 188c045fdb6366eb203d7520bb55ab914fa2d7d7
Author: Arik Fraimovich <arik@arikfr.com>
Date: Thu Nov 8 11:20:05 2018 +0100
Add Kylin logo (#3054)
commit 57d921dc2b44fb4dcb68235b4668ef1fde2ce503
Author: Omer Lachish <omer@rauchy.net>
Date: Thu Nov 8 11:48:45 2018 +0200
Druid query runner (#3047)
* add Druid query runner skeleton
* enable Druid only if package is available
* add Druid
* remove redundant override
* correct configuration schema
* implements run_query
* implement get_schema
* remove username and password
* fix small lint issues
* proper indentation
* add correct type mapping
commit df0804c8fd97c7ec5ba609587a6a7a3fa1361c50
Author: Xin Bai <1145490031@qq.com>
Date: Thu Nov 8 17:24:05 2018 +0800
Add Kylin plugin for SQL query (#2936)
commit c289dde8067c17b2f259128256e6a7f98abb5906
Author: Alexander Leibzon <alexander.leibzon@gmail.com>
Date: Thu Nov 8 11:18:33 2018 +0200
Google analytics fix fixes #2965 (#3008)
* add PagerDuty as an Alert Destination
* remove comments
* add unknown state handling
* fixes
* revert setup.sh
* Remove test method.
* resolves #2965
* more elegant, as per Arik's suggestion
* Add missing whitespace.
commit b7cadca3b72d9028d5c6d0b61644f662f048e805
Author: Levko Kravets <levko.ne@gmail.com>
Date: Thu Nov 8 11:17:18 2018 +0200
Edit-in-place component ignored isEditable flag and didn't work on Groups page (#3049)
commit 43f82007070e3ad5a5ff16960f49faf6872915bb
Author: Sami Jaktholm <sjakthol@outlook.com>
Date: Thu Nov 8 10:53:04 2018 +0200
feat(redshift): hide tables the configured user cannot access (#2866)
The SVV_COLUMNS table used to determine the tables of a
Redshift database includes all tables, even those the
current user cannot access, by default. These tables clutter
the schema browser and make it harder for users to determine
which tables they should have access to.
These changes modify the Redshift query runner so that
tables the configured user cannot access are filtered
out from the database schema. The checks are two-fold:
* First, the query uses HAS_SCHEMA_PRIVILEGE to check if the
current user has USAGE rights on a schema the given table
belongs to. This privilege is required to access any of
the tables in a schema.
* Second, the query tries to determine if the current user
has SELECT access to the given table. Two cases need to
be considered here:
* First, we need to check if the table is part of an
external schema. Access to tables in external schema
is controlled at schema level - you cannot grant or
revoke access to specific external tables. Additionally,
the HAS_TABLE_PRIVILEGE returns an error if it is asked
to give a verdict for an external table.
Hence, the query checks if the schema a specific table
belongs to is an external schema and if it is, the table
is included in the list (if we got here the user already
had USAGE on the given schema). This check short-circuits
the table-level access check for external tables which
means they are never passed to HAS_TABLE_PRIVILEGE().
* Then, if the table was not part of an external schema,
the HAS_TABLE_PRIVILEGE() function is used to determine
if the user has SELECT access to the given table. The
table is included in the schema if this check passes.
Together this condition ensures that tables the user definitely
cannot access are not included in the schema browser.
These changes have been tested to work in an environment that
includes normal and external schemas, normal and late-binding
views, and normal and external tables.
commit a1b580bba6a52a2e9491e811c6ab194ca4fe1edc
Author: Arik Fraimovich <arik@arikfr.com>
Date: Wed Nov 7 17:21:31 2018 +0100
Fix Docker Compose version number in Cypress config (#3051)
* Update Docker compose version
* Experiment with Docker-Composeless CI build
* Switch back to Docker compose based tests
commit 19d0313ea231c66f002252f1394baa5f2b0ca23b
Author: Zsolt Kocsmárszky <kocsmy@gmail.com>
Date: Wed Nov 7 16:58:15 2018 +0100
Fixing tag issues (#3006)
* Add title="" for tags
* Fix lines
* Fix long tag and overlaying tag issues on queries
commit 667fe43e23d2a09a7330e4679278a992da5310df
Author: Arik Fraimovich <arik@arikfr.com>
Date: Wed Nov 7 16:57:37 2018 +0100
Revert "address tag display on query list page" (#3050)
* Revert "remove pytest_watch (#3048)"
This reverts commit 096eba387644b2cbe3e4c314c223417f53ad0f0e.
* Revert "address tag display on query list page (#2803)"
This reverts commit 99115a12e60611639365cac5f378e05fe1b951bb.
commit 096eba387644b2cbe3e4c314c223417f53ad0f0e
Author: Omer Lachish <omer@rauchy.net>
Date: Wed Nov 7 17:49:41 2018 +0200
remove pytest_watch (#3048)
commit 99115a12e60611639365cac5f378e05fe1b951bb
Author: Alison <alison985@users.noreply.github.com>
Date: Wed Nov 7 09:12:31 2018 -0600
address tag display on query list page (#2803)
* address tag display on query list page
* character limit tags in css
* updates to tags on levko's feedback
commit 7d601cbbc963cb3ae2ee40e759ffad65bb39010f
Author: Gabriel Dutra <nesk.frz@gmail.com>
Date: Wed Nov 7 11:37:08 2018 -0200
Cypress based E2E tests (#3019)
commit bf6a09c5aa6f52ce362f106f1c6336115cc40967
Author: GitSumito <GitSumito@users.noreply.github.com>
Date: Wed Nov 7 00:45:39 2018 +0900
CLI sort (#3041)
commit 99967e720fd00ef2349af02598f8970346091611
Author: Yossi-a <yosiayun@gmail.com>
Date: Mon Nov 5 04:47:42 2018 +0200
Sort columns with undefined values (#2745)
* sort should treat undefine value as the minimal value
* explicit undefined check
commit 27f489de206521e1e912c47845ae2d43adaba60e
Author: Arik Fraimovich <arik@arikfr.com>
Date: Sun Nov 4 12:12:13 2018 +0200
Build docker image on master branch. (#3039)
commit 46941d3aa159131c216b6e2199e4fe12394224dd
Author: yoavbls <yoavbls@gmail.com>
Date: Thu Nov 1 15:58:50 2018 +0200
Update Flask-Admin to 1.5.2 (#3036)
I don't know if someone uses flask-admin but I upgraded it because of this bug:
https://github.com/flask-admin/flask-admin/issues/1588
In 1.4.2 you cant add and edit records/
commit 60c230add7277b7af741b2ec769e9cd177a34de2
Author: Levko Kravets <levko.ne@gmail.com>
Date: Thu Nov 1 15:57:39 2018 +0200
getredash/redash#3034 Postgres query runner: handle NaN/Infinity values (#3035)
commit 0784a0c6f5bfd49baa965ccf0ca0d95737f0926d
Author: Takuya Arita <takuya.arita@gmail.com>
Date: Wed Oct 31 18:05:17 2018 +0900
Add some tests for Query Results (#3031)
commit 9288d89248c2b39a922a2bf1fcbac8d10bbc49a9
Author: Zsolt Kocsmárszky <kocsmy@gmail.com>
Date: Mon Oct 29 21:09:49 2018 +0100
Fix query result section (#2980)
commit 391fbe130bdf96e1c36aeb2144ceadcacc10309e
Author: Levko Kravets <levko.ne@gmail.com>
Date: Mon Oct 29 22:08:35 2018 +0200
getredash/redash#2998 Charts lose responsive features after refreshing the dashboard (#3024)
commit e25c8c41450a8d802c5e8e1f10d6d14f7cc8d0cd
Author: Levko Kravets <levko.ne@gmail.com>
Date: Mon Oct 29 11:38:29 2018 +0200
getredash/redash#3022 Toolbox covers part of the chart (#3023)
commit 57353d1b405a1068dada4c1de9d7329ea92112ec
Author: Arik Fraimovich <arik@arikfr.com>
Date: Sun Oct 28 15:58:20 2018 +0200
Add -beta to version
commit 7f4e08154fd3ac688219d056e9ec2297d9cebbcc
Author: Arik Fraimovich <arik@arikfr.com>
Date: Sun Oct 28 15:56:32 2018 +0200
Bump version
commit 500c82815b60e6dbbff7bd1c57647dfebe70ef57
Author: Arik Fraimovich <arik@arikfr.com>
Date: Sun Oct 28 15:31:27 2018 +0200
Add netlify config (#2999)
commit 4a846f04e9aa04fbe2ab1591ce5a947cc2848dd6
Author: Arik Fraimovich <arik@arikfr.com>
Date: Sun Oct 28 11:11:11 2018 +0200
Add settings to import
commit b1e9d87e2a67b502e39c039db98f8c84f6b2b851
Author: Takuya Arita <takuya.arita@gmail.com>
Date: Sun Oct 28 17:40:07 2018 +0900
Apply query format options from settings (#2342)
* Apply query format options from settings
* Apply sqlparse format options via env-vars
commit ab6ed7da34dd2797914382c435981450b7bf9d7a
Author: Arik Fraimovich <arik@arikfr.com>
Date: Tue Oct 23 09:49:24 2018 +0300
Fix: setup.sh fails when run as root. (#2996)
Closes #2979
commit 2e6883c5276b4e5774083439c80cf1b55a54780f
Author: GitSumito <GitSumito@users.noreply.github.com>
Date: Sun Oct 21 17:40:07 2018 +0900
Add "Users" users are belong to into groups list (#2991)
commit 4c44999b2c52b09beae5a419b24a7cc574fa3412
Author: YOSHIDA Katsuhiko <claddvd@gmail.com>
Date: Sun Oct 21 17:39:37 2018 +0900
Fix an invalid prop type warning (#2992)
commit 34c118cf83e1c2e40de40cb1f6aa255ba16bedb5
Author: deecay <deecay@users.noreply.github.com>
Date: Sun Oct 21 17:39:06 2018 +0900
Add: Heatmap chart visualization by Plotly (#2080)
commit 38a89b9783439cca5253f0184e4e676e4927be5c
Author: Arik Fraimovich <arik@arikfr.com>
Date: Sun Oct 21 11:38:47 2018 +0300
Table visualization: change default size to 25 and add more size options. (#2982)
commit 6e836795b28e9fecd05bfc9b2e642f3a429bf248
Author: YOSHIDA Katsuhiko <claddvd@gmail.com>
Date: Sun Oct 21 17:38:11 2018 +0900
Fix url scheme (#2994)
commit 719fc41dd1cf0d3d81907cdde61f41fb6debe66c
Author: YOSHIDA Katsuhiko <claddvd@gmail.com>
Date: Sat Oct 20 21:33:31 2018 +0900
Add page size settings (#2993)
Add page size settings.
| name | default | description |
| :---- | :------ | :---------- |
| `REDASH_PAGE_SIZE` | 20 | How many items are displayed in one page as default. |
| `REDASH_PAGE_SIZE_OPTIONS` | 5,10,20,50,100 | How many steps as page_size. |
This feature has requested at the meetup in Japan.
https://redash-meetup.connpass.com/event/101420/
commit 467ec201dac375fda655ef8263460f427e6647b2
Author: Arik Fraimovich <arik@arikfr.com>
Date: Fri Oct 19 19:04:02 2018 +0300
Add Jest based tests to our stack (#2985)
* Add Jest packages
* Add first test
* Install eslint rules for jest & move deps to dev
* Configure cirlce to run jest
* package.json: Remove dev command
* package.json: clean command
* Don't autoload test files.
* Fix: webpack-dev-server was recompiling all the files on every change
* Update CircleCI step names
commit 5ab143de41b2a169848b63541bc19222c94cb80f
Author: koooge <koooooge@gmail.com>
Date: Fri Oct 19 18:25:24 2018 +0900
Rearrange make target (#2989)
commit 284e497483af6005a07e04e2bba85a0cef2b163e
Author: Arik Fraimovich <arik@arikfr.com>
Date: Fri Oct 19 11:00:33 2018 +0300
Databricks updates: logo, name and enable by default (#2983)
* Add Databricsk logo.
* Enable it by default.
* Rename to Databricks.
commit c5613dddf1d78cb001e2bb590c21e83f16184bc1
Author: dmonego <dmonego@gmail.com>
Date: Thu Oct 18 14:21:47 2018 -0400
Chnage: switch to Webpack 4 (#2933)
commit 34fb3ac79f11cf2055f86cb359a2ce068c3c6c96
Author: Arik Fraimovich <arik@arikfr.com>
Date: Thu Oct 18 17:33:58 2018 +0300
Change: add timeout to destination requests. (#2960)
commit 5f58c328f16593756a6af8ca46be8807776cc787
Author: Arik Fraimovich <arik@arikfr.com>
Date: Thu Oct 18 17:33:24 2018 +0300
MongoDB: skip system collections when loading schema. (#2961)
commit 7d1dbb87dbe83d13f1ad1d271d4dab96fea8cbcb
Author: Arik Fraimovich <arik@arikfr.com>
Date: Thu Oct 18 17:32:43 2018 +0300
Change: update MongoDB requirements to support srv. (#2962)
commit 45f4d462451f1cadea06fd80cde531c649ba2380
Author: GitSumito <GitSumito@users.noreply.github.com>
Date: Thu Oct 18 23:32:21 2018 +0900
Add "Groups" users are belong to into users list (#2967)
commit 44d05c35ac58f7a786ba2932e5d5269b8936ea20
Author: Arik Fraimovich <arik@arikfr.com>
Date: Thu Oct 18 17:31:48 2018 +0300
Presto query runner improvements (#2968)
* Presto: support for setting protocol (http/https).
* Presto: safe loading error message.
commit edd2cb85f7820510ab93526234839a18362c7624
Author: Arik Fraimovich <arik@arikfr.com>
Date: Thu Oct 18 14:59:00 2018 +0300
Update CHANGELOG.md
commit 6c364369bb0eb98e2191c2e502fed72abe5a74c7
Author: Hiroka Zaitsu <zaimy@users.noreply.github.com>
Date: Thu Oct 18 15:43:28 2018 +0900
Fix: TreasureData data source - deduplicate column names (#2867)
* Fix: TreasureData data source - deduplicate column names
* Maping types
commit 869841b2ac387bea3e1c04e3053b5eb343a80c2a
Author: YOSHIDA Katsuhiko <claddvd@gmail.com>
Date: Thu Oct 18 03:55:58 2018 +0900
Preventing open redirection (#2906)
* Prevent open redirection attack
* Add redirection url after logging in test
* Sanitize url just before redirecting it
* Consider when next parameter is None
commit c71f722552144cf73c38438ad45982b509fa3d6b
Author: Arik Fraimovich <arik@arikfr.com>
Date: Tue Oct 16 15:23:00 2018 +0300
Query Results query runner improvements: (#2969)
- Show meaningful error when failing to create table.
- Quote column names to allow more characters types.
commit af3a1e00c6ccf583da73b37d182a9405ecb5f0ab
Author: Jannis Leidel <jannis@leidel.info>
Date: Tue Oct 16 10:38:37 2018 +0200
Fix #2757 - Use full text search ranking when searching in list views. (#2798)
This applies to the queries, dashboard and users views.
commit 5b2ec81e65e270595fca37366fb03c380da87b5d
Author: Gabriel Dutra <nesk.frz@gmail.com>
Date: Mon Oct 15 17:08:18 2018 -0300
Fix no tags shown when having empty set (#2964)
commit 0008e5803b487f07ed555aaed2074b55164db115
Author: Vladislav Denisov <denisov@sports.ru>
Date: Mon Oct 15 20:06:16 2018 +0300
clickhouse: move timeout to params (#2956)
* clickhouse: timeout moved to params
* clickhouse: use get() method for timeout
commit e1c1f67abb3745bf0122fc7949aea988f2da660a
Author: Arik Fraimovich <arik@arikfr.com>
Date: Mon Oct 15 20:05:40 2018 +0300
Add: option to auto reload widget data in shared dashboards. (#2959)
commit 30283235a4f471e5d5cd0fe55349b314dd83f622
Author: Marina Samuel <msamuel@mozilla.com>
Date: Mon Oct 15 13:05:07 2018 -0400
Fix tarball build failure. (#2963)
commit 845e33b3968d68d074e280002f76a4b09ef53053
Author: Levko Kravets <levko.ne@gmail.com>
Date: Mon Oct 15 19:59:05 2018 +0300
Query page layout improvements for small screens (#2922)
* getredash/redash#2796 Make entire page scrollable on small screens; improve metadata block
* getredash/redash#2796 Improve query page header layout; fix small bugs (margins, etc.)
commit 17baa6618821ceca3306ca6fce00d5f5f3fe2e26
Author: Arik Fraimovich <arik@arikfr.com>
Date: Mon Oct 15 17:45:22 2018 +0300
Show "Add description" only after saving the query. (#2958)
Closes #2897
commit 5df7bd12c9e0977fea408126f69d5cec12820d61
Author: Arik Fraimovich <arik@arikfr.com>
Date: Mon Oct 15 17:38:22 2018 +0300
Fix: apply missing CSS classes to EditInPlace component. (#2957)
commit e14c8b61a0141615704db04dffbd5c5f7ee98450
Author: Nicolas Ferrandini <nicolas.ferrandini@gmail.com>
Date: Mon Oct 15 16:13:39 2018 +0200
Add DB2 as a data source using ibm-db python package (#2848)
* Add DB2 as a data source using ibm-db python package
* fix some codeclimate issue
* fix long line and missing white space
* Manage case of bad import
* Add DB2 query_runner as default query runner
* Fixed minor PEP8 rules
commit a8a3ec66fd730ca260e903e95db39490b26d550c
Author: Arik Fraimovich <arik@arikfr.com>
Date: Mon Oct 15 16:01:38 2018 +0300
Bring back fix to Box plot hover. (#2941)
commit a4b9c2da122b806504931c3e7e00a75315086c67
Author: GitSumito <GitSumito@users.noreply.github.com>
Date: Mon Oct 15 21:57:51 2018 +0900
fixed https://github.com/getredash/redash/issues/2950 (#2951)
* fixed https://github.com/getredash/redash/issues/2950
* fixed test code
* Effective -> Active. thank you @kravets-levko
commit e6146dae0fb6e4b60ee42cf270dfb09c7a818f9a
Author: Vladislav Denisov <denisov@sports.ru>
Date: Mon Oct 15 15:03:02 2018 +0300
Clickhouse fixes (#2953)
* clickhouse: avoid last line with comment in query
* clickhouse: add request timeout
commit bd3fe880a4831c6ddf798822973a7b8d7d9267c3
Author: Levko Kravets <levko.ne@gmail.com>
Date: Mon Oct 15 14:51:13 2018 +0300
Add missing default "extensions" directory (webpack fails to build without it) (#2952)
commit 02e919c39bd495cb9dd2ec1021b3225dcf42b213
Author: Marina Samuel <msamuel@mozilla.com>
Date: Sun Oct 14 08:53:39 2018 -0400
Closes #2565: Add frontend extension capability. (#2799)
commit 99c73aef2d925cac269dbfd2b763b6961f68992f
Author: Arik Fraimovich <arik@arikfr.com>
Date: Sun Oct 14 14:39:52 2018 +0300
Update snowflake_connector_python version (#2946)
commit be377b5f594ba1715c429f0182e3ea2e00e22a9b
Author: Ralphilius <4253551+ralphilius@users.noreply.github.com>
Date: Sun Oct 14 15:23:20 2018 +0700
Add Counter label (#2900)
* Add Counter label
* Update index.js
* Added visualization name as placeholder
* Backward-compatible for visualization name as label
commit 6b11ae43125d352ffd2fa8f193ef24bf6c745a72
Author: Zsolt Kocsmárszky <kocsmy@gmail.com>
Date: Sun Oct 14 10:00:27 2018 +0200
Design refinements (#2927)
* Fix search size on smaller tablet size
* Less prominent tag counter
* Fix hiding logo
* Add missing space between icon and button text
* Different embed icon
* Revert embed icon to its original
* Better edit source icon + markup cleanup
commit 9021977a54b591f2a3f60ec355cc2207f905fd2e
Author: YOSHIDA Katsuhiko <claddvd@gmail.com>
Date: Sun Oct 14 16:49:11 2018 +0900
Fix admin api recording (#2937)
commit 9c8d06578ae7e2a807179d22829443aebc9c97d6
Author: Sami Jaktholm <sjakthol@outlook.com>
Date: Sun Oct 14 10:42:31 2018 +0300
feat: add support for expanding dashboard visualizations (#2824)
* feat: add support for expanding dashboard visualizations
These changes implement support for expanding a dashboard visualization
into a larger modal dialog.
This is useful if you have a dashboard with lots of small widgets and
want to inspect one of the widgets more closely. In the past, this
would've required you to navigate to the query page to see a larger
version of the visualization. With these changes, visualizations can
be expanded right from the dashboard.
The implementation is simple as it just renders the visualization into
a modal dialog. Other parts of the widget (e.g. parameters) are not
included in this dialog.
* chore(widget-dialog): use query-link widget to render title
This reduces code duplication a bit. The link is made read-only
as navigation doesn't close the modal dialog.
* fix: make ui-select dropdown z-index > modal dialog z-index in dashboard page
Otherwise the dropdown renders behind the modal dialog if filter value
is changed from the modal view of a widget.
commit 114beb24806572741a80cb455bf3e98a40f8448b
Author: YOSHIDA Katsuhiko <claddvd@gmail.com>
Date: Sun Oct 14 16:39:08 2018 +0900
Auto focus tag input (#2938)
commit e97a5cbb29e3fe5ffea05d5fc4a9ca70f8801cee
Author: Alexander Leibzon <alexander.leibzon@gmail.com>
Date: Sun Oct 14 10:35:39 2018 +0300
add PagerDuty as an Alert Destination (#2903)
commit e87efc8bc30cefa0176fea7f12169cf202452727
Author: Alexander Leibzon <alexander.leibzon@gmail.com>
Date: Thu Oct 11 21:07:20 2018 +0300
fixes #2924 (#2931)
Google Spreadsheets: support for open by url
commit be7f601d21cf2b8748ec918b72323caab8da30ab
Author: Arik Fraimovich <arik@arikfr.com>
Date: Thu Oct 11 14:12:28 2018 +0300
Speed up builds by skipping installing requirements_all_ds.txt in CI unit tests (#2928)
* Speed up builds by skipping requirements_all_ds.txt
* Update docker compose file version
* Start services before running commands
* Add boto and Athena dependencies to requirements_dev.txt
commit 9b59d10677717796c0ee91bd2420e9fe5b083270
Author: Levko Kravets <levko.ne@gmail.com>
Date: Thu Oct 11 12:27:28 2018 +0300
Use Plotly's function to clean y-values (x may be category or date/time) (#2872)
commit a40669e07f0fa3829b5313f2834c390a8b79a89e
Author: Levko Kravets <levko.ne@gmail.com>
Date: Thu Oct 11 11:23:40 2018 +0300
getredash/redash#2875 Update plotly.js; some cleanup; fix chart legend issue in horizontal mode (#2902)
commit 0bcf5d4be761ceb8d94b47bb636ef2a6afc4db45
Merge: 6ea03e58 8bc96764
Author: Levko Kravets <levko.ne@gmail.com>
Date: Thu Oct 11 09:08:31 2018 +0300
Merge pull request #2929 from combineads/fix-date-filter
Fix: date value in a filter is duplicated.
commit 8bc96764a6c3aca5939ab3477c19f7be86845273
Author: combineads <combine@combineads.co.kr>
Date: Thu Oct 11 14:56:57 2018 +0900
Fix: date value in a filter is duplicated.
commit 6ea03e58b41cb543c550348bf9d4923b7f4ce047
Author: Niko Eckerskorn <kadrach@users.noreply.github.com>
Date: Thu Oct 11 03:13:48 2018 +1100
Address edgecase when retrieving Glue schemas for Athena query runner. (#2868)
Fixes getredash/redash#2858
commit 94801665abce630a4441339753ee0880935c3330
Author: Gabriel Dutra <nesk.frz@gmail.com>
Date: Wed Oct 10 09:07:11 2018 -0300
Fix output file name not changing after rename query (#2917)
commit aa12151e191176c4899bc3fd990c76d17843bc4f
Author: Gabriel Dutra <nesk.frz@gmail.com>
Date: Wed Oct 10 08:56:31 2018 -0300
Fix export query results output file name (#2916)
- regexp `/ /g` will seek for all space ocurrences, not only the first
commit c2429e92d2a5dd58cbe378b9cc06f3be969f747e
Author: Jannis Leidel <jannis@leidel.info>
Date: Tue Oct 9 15:38:06 2018 +0200
Consistently use simplejson to loading and dumping JSON. (#2817)
* Consistently use simplejson to loading and dumping JSON.
This introduces the new functions redash.utils.json_dumps and redash.utils.json_loads and simplifies the custom encoder setup.
UUIDs are now handled by the default encoder, too.
Fixes #2807.
Use string comparison in parse_boolean instead of the (simple)json module.
commit 5ffc85c066e5f1f156e736b5d7262ca210f5495f
Author: Jannis Leidel <jannis@leidel.info>
Date: Mon Oct 8 12:06:58 2018 +0200
Extend menu item text a bit for visual consistency.
commit fad757c878aad6d2d0e7ad5cb814b2f0b771cbe5
Author: Jannis Leidel <jannis@leidel.info>
Date: Mon Oct 8 12:05:25 2018 +0200
Don’t show “Add to dashboard” in dropdown to unsaved queries.
commit 3351a281eea748f2cf2c8f16295ac6de875f40e4
Author: Jannis Leidel <jannis@leidel.info>
Date: Mon Oct 8 12:03:54 2018 +0200
Fix webpack build error about BigMessage. (#2910)
commit 1f0053f531a7455a5aa866bbeda34f5991e29877
Author: Arik Fraimovich <arik@arikfr.com>
Date: Mon Oct 8 10:05:16 2018 +0300
MySQL: hide sys tables (#2909)
commit 935dc3836087ecc83e735d4c036ff49507aaed49
Author: Arik Fraimovich <arik@arikfr.com>
Date: Mon Oct 8 09:41:15 2018 +0300
Update setup files: (#2908)
* Remove use of newgrp
* Updated packer configuration
commit bfef7fae93ebb1fbfb464021afd295620d81de82
Author: Arik Fraimovich <arik@arikfr.com>
Date: Mon Oct 8 09:39:57 2018 +0300
Remove unused dependencies. (#2907)
Closes #2782
commit da6d456f6feb4c7c385e44e7efc9abb8a13a5deb
Author: cclauss <cclauss@bluewin.ch>
Date: Fri Oct 5 12:48:01 2018 +0200
CircleCI: Flake8 tests passing on Legacy Python and Python 3 (#2881)
commit c19199c2fbb29c6c9d4c4df47382af0b3e7b2976
Author: Arik Fraimovich <arik@arikfr.com>
Date: Thu Oct 4 12:34:03 2018 +0300
Add margin between format and autocomplete buttons (#2899)
commit 1e78861f85bb92e6aa16746b8bcce52574498e6b
Author: Arik Fraimovich <arik@arikfr.com>
Date: Thu Oct 4 12:27:36 2018 +0300
Move Ant styles into a central location. (#2898)
This is to ensure that we include our override after loading Ant's styles.
commit 10bc5a0bf66500f1036166027b02609f04b6d82d
Author: Arik Fraimovich <arik@arikfr.com>
Date: Thu Oct 4 12:01:38 2018 +0300
Remove misplaced bracket. (#2894)
commit 313af904df75f2c665ad0e0f488431204ddf8f22
Author: Marina Samuel <msamuel@mozilla.com>
Date: Thu Oct 4 02:07:58 2018 -0400
Add ability for extensions to add periodic tasks. (#2740)
commit 8c478087a91f770f51517f04f37d90068571a9e3
Author: Allen Short <ashort@mozilla.com>
Date: Wed Oct 3 19:25:19 2018 +0000
Rewrite query editor to React (#2636)
commit ccac41c6d4d877f88e3c2291679390c11103d4fd
Author: Arik Fraimovich <arik@arikfr.com>
Date: Tue Oct 2 16:22:47 2018 +0300
Fix: JS build breaks because registerAll tries to run EditInPlace component (#2886)
commit 69635f2c401406e629bb0a68e7d117d920a2dc0d
Author: Jannis Leidel <jannis@leidel.info>
Date: Tue Oct 2 15:11:01 2018 +0200
Rename Yandex Metrika to Metrica. (#2884)
Fix #2874.
commit 1867ea50bbf702270f77209bbf217ffd44b8c300
Author: yoavbls <yoavbls@gmail.com>
Date: Tue Oct 2 16:05:41 2018 +0300
Add option to query cached results (#2855)
commit c64d5ef6c05dd3e393ac3c56a6a959819562b395
Author: Jannis Leidel <jannis@leidel.info>
Date: Mon Oct 1 21:29:20 2018 +0200
Fix #2876 - Remove accidental query-result-link component from 'Add to dashboard link.' (#2883)
commit e3a63899d35a981ff1b1aad0ff192ba19b816aed
Author: Alison <alison985@users.noreply.github.com>
Date: Mon Oct 1 04:11:32 2018 -0500
Add ability to search table column names in schema browser (#2681)
commit 4685887fe549a4ba7248aa4bb11a146d41e4791b
Author: Jannis Leidel <jannis@leidel.info>
Date: Fri Sep 28 21:55:47 2018 +0200
Fix name of edit-in-place React component.
commit f103357e600755b08f933daf210479a80f2e5193
Author: Arik Fraimovich <arik@arikfr.com>
Date: Fri Sep 28 22:45:13 2018 +0300
Fix: wrong reference (EditInPlaceText -> EditInPlace)
commit 11738f73ac937204ec7d256eb082bcb3e8a12701
Author: Jannis Leidel <jannis@leidel.info>
Date: Thu Sep 27 17:31:31 2018 +0200
Removed redundant exception handling since execute_query task handles that.
commit d07c4f969be0097ad66c201bdf85f67896a31f85
Author: Allen Short <ashort@mozilla.com>
Date: Wed Feb 7 20:01:51 2018 +0000
Support authentication for the URL query runner.
Adds a new BaseHTTPQueryRunner class and tests.
commit 505aafbce364eb2bf95ae38cce41cad8671be5c1
Author: Allen Short <ashort@mozilla.com>
Date: Fri Sep 28 19:30:10 2018 +0000
Convert edit-in-place component to React (#2637)
commit b7656938797dacda97545d69f8e628e75dd62202
Author: Marina Samuel <msamuel@mozilla.com>
Date: Fri Sep 28 15:28:30 2018 -0400
Upgrade Celery to 4.2.1. (#2773)
commit 4620fed0cf20306407abcf0a1a318f0af33700f6
Author: Jannis Leidel <jannis@leidel.info>
Date: Fri Sep 28 16:24:13 2018 +0200
Use server side sort order for tag list and show count of tagged items. (#2833)
* Use tag list ordering from backend.
This basically stops resorting the tag list on the client side and use the already existing (and correct) descending sort order bu tag usage count from the backend.
* Show count of tagged items in tag list.
commit 48ad1d2dce8ebeb6a3893cba9331eccc175bff4c
Author: Arik Fraimovich <arik@arikfr.com>
Date: Fri Sep 28 17:18:41 2018 +0300
Add v5.0.1 to the CHANGELOG.
commit f2c323a0897adec943427d533d6f1a871aca26c8
Author: Arik Fraimovich <arik@arikfr.com>
Date: Fri Sep 28 11:52:14 2018 +0300
Disable integration tests
The integration tests are currently not failing and providing false positives when running them. I'm disabling this until the test suite is more stable.
@jrbenny35 @jezdez
commit ec17cc7eabdadf057a98bbf0684cc4c5ef077c5f
Author: Levko Kravets <levko.ne@gmail.com>
Date: Fri Sep 28 11:26:37 2018 +0300
getredash/redash#2854 Widget titles wrong rendering on public dashboards (#2870)
commit 6c7bbe9041304c546cfac2590590f1b344d894f0
Merge: 551b0222 2b0e6e9e
Author: Arik Fraimovich <arik@arikfr.com>
Date: Thu Sep 27 21:47:56 2018 +0300
Merge branch 'master' of github.com:getredash/redash
commit 551b0222c4eff0ac21e7f71567b59902dbe4c422
Author: Arik Fraimovich <arik@arikfr.com>
Date: Thu Sep 27 21:47:45 2018 +0300
Cleanup packer configuration
commit 2b0e6e9e790c1f1c9b782887e1ca871726437bf5
Author: Jannis Leidel <jannis@leidel.info>
Date: Thu Sep 27 17:06:26 2018 +0200
Refactor list based controllers. (#2790)
This reduces the code duplication between the dashboard, user and queries list pages and normalizes many of the APIs between them.
This also:
- allows sorting query favorites
- adds a pagination size select to the dashboard list
- fixes a bunch of UI inconsistencies between the queries and dashboards list (e.g. margins)
The new ListCtrl class is subclassed in the various specific page controllers and extended as needed. New list pages can make use of the same pattern in the future.
This also adds some missing event recordings from 34e39eda4a02916380b47c1e20849a372926e083.
commit 4727c192539c0f7b29092a786ca270e3e0540e8f
Author: Levko Kravets <levko.ne@gmail.com>
Date: Thu Sep 27 13:27:10 2018 +0300
getredash/redash#2796 Improve counter text scaling (#2840)
commit 2ff4d07e83e5618d42f7b12962bee47214ad73fb
Merge: 1997f53f 28fbc2ae
Author: Arik Fraimovich <arik@arikfr.com>
Date: Thu Sep 27 12:34:28 2018 +0300
Change placement (right/bottom) of chart legend depending on chart width (#2852)
Closes getredash/redash#2796.
commit 1997f53f40a44e37c0c6736d315ebe2943306585
Author: Arik Fraimovich <arik@arikfr.com>
Date: Thu Sep 27 10:36:48 2018 +0300
Fix CircleCI setup for release branches. (#2859)
commit c03b5d51b7870ac3948797da936b1d12b8167ade
Author: Jannis Leidel <jannis@leidel.info>
Date: Thu Sep 27 09:20:07 2018 +0200
Simplified data source resource. Refs #2856.
commit 197665bb6af92de8300e75c4af60432ecf0b4437
Author: yoavbls <yoavbls@gmail.com>
Date: Thu Sep 27 10:15:36 2018 +0300
Fix bug in DataSourceResource load (#2857)
commit 28fbc2ae624483cffa04630591801c58c0ba1378
Author: Levko Kravets <levko.ne@gmail.com>
Date: Wed Sep 26 18:46:49 2018 +0300
getredash/redash#2796 Change placement (right/bottom) of chart legend depending on chart width
commit ea1c4ca85c601427d5077295d367c8ab23d34835
Author: Alexey Korobkov <afireinside47@gmail.com>
Date: Wed Sep 26 23:17:48 2018 +0500
Add auth via JWT providers (#2768)
* authentication via JWT providers
* add support for IAP JWT auth
* remove jwt_auth Blueprint and /headers endpoint
* fix pep8: imports
commit 588e0cce43d27faa8b8196ac0d4cc5c8ed7c36e4
Author: Alison <alison985@users.noreply.github.com>
Date: Wed Sep 26 10:32:38 2018 -0500
Add autocomplete toggle (#2780)
commit 8a50351520067fc3af6593263d8e1cc376292443
Author: Alison <alison985@users.noreply.github.com>
Date: Wed Sep 26 10:29:38 2018 -0500
Add ability to add viz to dashboard from query edit page (#2767)
commit 34e39eda4a02916380b47c1e20849a372926e083
Author: Alison <alison985@users.noreply.github.com>
Date: Wed Sep 26 10:17:46 2018 -0500
Port moving events serverside (#2766)
commit 28a8525ce3fb24d303132c52109b5d62c67fae4f
Author: Alison <alison985@users.noreply.github.com>
Date: Wed Sep 26 10:07:03 2018 -0500
Add databricks query runner (#2747)
Fixes #2685.
commit 5e70f9c04a864feb8165058c3201c793cb66604e
Author: Arik Fraimovich <arik@arikfr.com>
Date: Tue Sep 25 21:08:46 2018 +0300
Update README.md
commit a05b5ba68deca88bfbed3eebf462d84de5e96d96
Author: Arik Fraimovich <arik@arikfr.com>
Date: Tue Sep 25 21:08:24 2018 +0300
Docker based setup scripts (#2850)
commit 40ba66c58eae3a1181f8f2e9e4e9555bcdc632ef
Author: Dan VerWeire <dverweire@gmail.com>
Date: Tue Sep 25 12:12:04 2018 -0400
Fix invalid reference to alert.to_dict() in webhook (#2849)
kravets-levko
deleted the
bug/chart-legend-not-updated-on-page-refresh
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2998