Add phoenix query runner. #3153
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We would appreciate it if you could provide us with more info about this issue/pr! |
request-info
bot
added
the
Needs More Information
|
@arikfr May I ask you for a review? |
arikfr
reviewed
Dec 26, 2018
redash/query_runner/phoenix.py
Outdated
| except Exception as ex: | ||
| json_data = None | ||
| error = 'error.{}.{}'.format(query, ex) | ||
| if not isinstance(error, basestring): |
redash/query_runner/phoenix.py
Outdated
| json_data = None | ||
| except Exception as ex: | ||
| json_data = None | ||
| error = 'error.{}.{}'.format(query, ex) |
There was a problem hiding this comment.
The error message is shown to the user and should be (to some degree) user friendly. Not sure this qualifies :)
Maybe returning just the exception message is enough?
There was a problem hiding this comment.
Error handling is sufficient. Users can identify errors with code and message. Please refer to https://python-phoenixdb.readthedocs.io/en/latest/api.html#phoenixdb.Error.
arikfr
removed
the
Needs More Information
ghost
added
the
|
@arikfr Thank you for your review. |
|
Thanks! |
harveyrendell
pushed a commit
to pushpay/redash
that referenced
this pull request
Nov 14, 2019
* Add phoenix query runner. * Improved error handling.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an apache phoenix query runner. The query runner presently does not support Kerberos authentication. But I plan to implement it soon.
