Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Closes #3294: Set schedule appropriately for forked queries. #3295

Closed
wants to merge 1 commit into from
Closed

Closes #3294: Set schedule appropriately for forked queries. #3295

wants to merge 1 commit into from

Conversation

emtwo
Copy link

@emtwo emtwo commented Jan 16, 2019

Set the schedule to empty values when forking. This allows the UI to correctly handle an "empty" schedule

Note @arikfr I'm aware that this might look different once #3277 is ready. But this is a quick fix we can have for now.

@ghost ghost assigned emtwo Jan 16, 2019
@ghost ghost added in progress labels Jan 16, 2019
@emtwo emtwo requested review from arikfr and ranbena January 16, 2019 17:41
@ranbena ranbena removed their request for review January 16, 2019 17:56
@ranbena
Copy link
Contributor

ranbena commented Jan 16, 2019

I'll defer this review to @arikfr.

@arikfr
Copy link
Member

arikfr commented Jan 17, 2019

Thanks, @emtwo!

But #3277 is ready to go and addresses this issue as well. To avoid conflicts, I'm closing this.

@arikfr arikfr closed this Jan 17, 2019
@ghost ghost removed in progress labels Jan 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arikfr arikfr Awaiting requested review from arikfr

Assignees

@emtwo emtwo

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@emtwo @ranbena @arikfr