Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Compact refresh schedule data #3378

Closed
wants to merge 1 commit into from
Closed

Compact refresh schedule data #3378

wants to merge 1 commit into from

Conversation

ranbena
Copy link
Contributor

@ranbena ranbena commented Jan 31, 2019

Removing any null values params from schedule object for efficiency.
Tested and works fine.

@ghost ghost assigned ranbena Jan 31, 2019
@ghost ghost added the in progress label Jan 31, 2019
@ranbena ranbena requested a review from arikfr January 31, 2019 11:49
arikfr
arikfr requested changes Jan 31, 2019
View reviewed changes
Copy link
Member

@arikfr arikfr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just realized this will require backend change too: currently we use the key exists, but now we need to use schedule.get instead of direct access.

@ranbena
Copy link
Contributor Author

ranbena commented Jan 31, 2019

@arikfr are you talking about a change to frontend or backend?

@weekly-digest weekly-digest bot mentioned this pull request Mar 10, 2019
Closed
@ranbena
Copy link
Contributor Author

ranbena commented Mar 23, 2019

#3341 has already been resolved

@ranbena ranbena closed this Mar 23, 2019
@ghost ghost removed the in progress label Mar 23, 2019
@ranbena ranbena deleted the compact branch March 23, 2019 10:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arikfr arikfr arikfr requested changes

Assignees

@ranbena ranbena

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ranbena @arikfr