Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Query Parameters: don't save urlPrefix #3427

Merged
merged 4 commits into from
Feb 12, 2019
Merged

Query Parameters: don't save urlPrefix #3427

Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
37ecc94
Query Parameters: don't save urlPrefix
kravets-levko Feb 12, 2019
086b21b
Merge branch 'master' into fix/query-parameters-save-urlprefix
kravets-levko Feb 12, 2019
ded3a7e
Merge branch 'master' into fix/query-parameters-save-urlprefix
kravets-levko Feb 12, 2019
b2ced4e
Make property non-enumerable instead of removing it on save
kravets-levko Feb 12, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion client/app/pages/queries/view.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import { pick, some, find, minBy, map, intersection, isArray, isObject } from 'lodash';
import { pick, some, find, minBy, map, intersection, omit, extend, isArray, isObject } from 'lodash';
import { SCHEMA_NOT_SUPPORTED, SCHEMA_LOAD_ERROR } from '@/services/data-source';
import getTags from '@/services/getTags';
import { policy } from '@/services/policy';
Expand Down Expand Up @@ -249,6 +249,9 @@ function QueryViewCtrl(
$scope.saveQuery(options, data);
}

request.options = extend({}, request.options);
request.options.parameters = map(request.options.parameters, param => omit(param, 'urlPrefix'));
arikfr marked this conversation as resolved.
Show resolved Hide resolved

return Query.save(
request,
(updatedQuery) => {
Expand Down