Avoid reporting bad requests to Sentry

[rauchy]

No description provided.

[arikfr]

Does this include 404s?

[rauchy]

@arikfr nope, only 400s. If you want 404s as well, smash this:

Suggested change

	NON_REPORTED_EXCEPTIONS = ['BadRequest', 'QueryExecutionError']
	NON_REPORTED_EXCEPTIONS = ['NotFound', 'BadRequest', 'QueryExecutionError']

[arikfr]

Only the author of the PR, can accept suggestions... Do you think we should keep reporting 404s there?

[rauchy]

The only thing I can think that we should keep 404s for is any manual construction of links in the frontend that might not pop up as a bug during development and testing.

[arikfr]

Two things about this:

1. In dev/test we don't send Sentry reports anyway.
2. This kind of issues should be tracked from the frontend.

[rauchy]

So where are we with regards to this PR? Do we still want to keep 400s after all?

[arikfr]

So where are we with regards to this PR? Do we still want to keep 400s after all?

I'm conflicted. On the one hand it feels to me that Sentry should receive only actionable issues. On the otherhand, it proved useful debugging a production issue 🤔

I will open a thread in Sentry's forum to see what they recommend.

[arikfr]

https://forum.sentry.io/t/what-to-do-about-inactionable-errors/6059

[guidopetri]

@rauchy , thanks for the PR! We've updated a lot of things now that we're Community-driven so - if you're still interested in getting this merged - would you mind rebasing off master to re-run the CI, as well as updating merge conflicts?

We're trying to clean up our PR todo list, so if you're not interested, that's fine - we'll close the PR in about a week if we don't hear back. If you're interested in reopening the PR afterwards, we would also very much welcome that.

[justinclift]

Looking over that message on the Sentry forums, it seems like sending the extra data does have uses:

We were about to filter those errors, but then we had a production issue resulting in a BadRequest exception.
Having all the data Sentry includes with each event was a god send and allowed to resolve this issue in
minutes.

So, lets not merge this PR. We can revisit this topic later on if this turns out to be a bad move. 😁