Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce volatility in embed percy snapshots #3672

Merged
merged 1 commit into from
Apr 2, 2019
+2 −2
Merged

Reduce volatility in embed percy snapshots #3672

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions client/cypress/integration/embed/share_embed_spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ describe('Embedded Queries', () => {
it('are shared with safe parameters', () => {
cy.getByTestId('QueryEditor')
.get('.ace_text-input')
.type('SELECT * FROM organizations WHERE id=\'{{}{{}id}}\'{esc}', { force: true });
.type('SELECT name, slug FROM organizations WHERE id=\'{{}{{}id}}\'{esc}', { force: true });

cy.getByTestId('TextParamInput').type('1');
cy.clickThrough(`
Expand All @@ -31,7 +31,7 @@ describe('Embedded Queries', () => {
it('cannot be shared with unsafe parameters', () => {
cy.getByTestId('QueryEditor')
.get('.ace_text-input')
.type('SELECT * FROM organizations WHERE name=\'{{}{{}name}}\'{esc}', { force: true });
.type('SELECT name, slug FROM organizations WHERE name=\'{{}{{}name}}\'{esc}', { force: true });

cy.getByTestId('TextParamInput').type('Redash');
cy.clickThrough(`
Expand Down