Dashboard save fail indication #3715
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I added an additional feature to the "done editing" button:
|
There was a problem hiding this comment.
Looks nice, I was actually annoyed by the fact that there was an unreachable primary button when it was saving, one last suggestion to it:
When dashboard is in saving state and users clicks the button - it changes to loading+disabled
till save completes.
Shouldn't it auto close edit mode when save completes with success? (It was actually the behavior I expected when testing it 😅)
Oh mannnnnn.. I've been working on the dashboard too long 🙃😖Fixed. |
gabrieldutra
approved these changes
Apr 19, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Description
Since dashboard auto-save #3653, in case of a failed save, there is a notification but it still says "Saved" at the top as @gabrieldutra rightfully indicated.
This PR adds another boolean flag
saveDelayto differentiate 3 states: Saved, Saving, Error.Mobile & Desktop Screenshots/Recordings (if there are UI changes)
In this recording I block my server url (with developer tools), get error and then turn back on, to demonstrate the flow.