Add an extras field for Presto connection
#3909
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Did you know that we have a Qubole query runner? |
|
Test summary
Run details
View run in Cypress Dashboard ➡️ This comment has been generated by cypress-bot as a result of your project's GitHub integration settings. You can manage this integration in your project's settings in the Cypress Dashboard |
|
Oops, didn't see that... But can this PR be of any use for other scenarios still? |
This is mostly for allowing self-assigned SSL certificate. For example, services like [Qubole](https://docs.qubole.com/en/latest/user-guide/presto/connect-to-presto-when-ssl-enabled.html) only allows SSL connection via self-assigned CA certificate. The default value (placeholder) should have made it obvious what this field is for for those who need it.
In lower version of Presto, sometimes the old query will throw "outputFormat should not be accessed from a null StorageFormat" error (see prestodb/presto#6972).
ktmud
added a commit
to ktmud/redash
that referenced
this pull request
Jun 20, 2019
This makes it possible to allow arbitrary connection parameters that are not stored as configuration field. Also extended Dynamic Forms to allow JSON validation.
1 task
ktmud
added a commit
to ktmud/redash
that referenced
this pull request
Sep 25, 2019
This makes it possible to allow arbitrary connection parameters that are not stored as configuration field. Also extended Dynamic Forms to allow JSON validation.
ktmud
added a commit
to ktmud/redash
that referenced
this pull request
Aug 14, 2020
This makes it possible to allow arbitrary connection parameters that are not stored as configuration field. Also extended Dynamic Forms to allow JSON validation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
Description
This added a new "Extras" fields for Presto connection,
mostly for allowing self-assigned SSL certificate.
For example, services like Qubole
only allows SSL connection via self-assigned CA certificate.
Example usage is to include
requests_kwargsas JSON string:{"requests_kwargs": {"verify": "~/qubole.cert"} }Related Tickets & Documents
Mobile & Desktop Screenshots/Recordings (if there are UI changes)