Expose celery job timeout setting to env var #3912
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test summary
Run details
View run in Cypress Dashboard ➡️ This comment has been generated by cypress-bot as a result of your project's GitHub integration settings. You can manage this integration in your project's settings in the Cypress Dashboard |
arikfr
reviewed
Jun 18, 2019
redash/settings/__init__.py
Outdated
| @@ -31,6 +31,8 @@ | |||
| CELERY_RESULT_EXPIRES = int(os.environ.get( | |||
| "REDASH_CELERY_RESULT_EXPIRES", | |||
| os.environ.get("REDASH_CELERY_TASK_RESULT_EXPIRES", 3600 * 4))) | |||
| CELERY_JOB_TIMEOUT = int(os.environ.get( | |||
There was a problem hiding this comment.
CELERY_JOB_TIMEOUT is a bit misleading here. How about CELERY_INIT_TIMEOUT?
|
Thanks! |
|
Just for record-keeping, this is considered a potential bug in Celery and may be fixed with an upstream fix: celery/celery#4323 |
harveyrendell
pushed a commit
to pushpay/redash
that referenced
this pull request
Nov 14, 2019
* Expose celery job timeout to env * Change variable name
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
Description
This PR allows users to define celery job timeout from environment variable. Environment variable is
REDASH_CELERY_INIT_TIMEOUTand the default value is 10 seconds.It should help people with limited computing resource seeing
[ERROR][MainProcess] Process 'ForkPoolWorker-19' pid:63 exited with 'signal 9 (SIGKILL)'in their logs.Related Tickets & Documents
This PR is an follow up of #3903.
Mobile & Desktop Screenshots/Recordings (if there are UI changes)