Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Data Sources] Initial commit for adding Dgraph support #3987

Merged
merged 7 commits into from
Aug 13, 2019

Conversation

The-Alchemist
Copy link
Contributor

What type of PR is this? (check all applicable)

  • Feature
  • New Query Runner (Data Source)

Description

Adding support for querying Dgraph.

Original PR was #3964

Copy link
Member

@arikfr arikfr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How do queries look like in Dgraph? I mean, what type of query language does it use?

redash/query_runner/dgraph.py Outdated Show resolved Hide resolved
@The-Alchemist
Copy link
Contributor Author

How do queries look like in Dgraph? I mean, what type of query language does it use?

Dgraph uses a variant of GraphQL they call GraphQL+- (https://docs.dgraph.io/query-language/). The output is JSON.

There might be a syntax highlighter for GraphQL+-. Should that be part of this PR, or a separate one?

Copy link
Member

@arikfr arikfr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your continued effort on this! I think this is the last round of comments before merging it in 👌

redash/query_runner/dgraph.py Outdated Show resolved Hide resolved
redash/query_runner/dgraph.py Outdated Show resolved Hide resolved
redash/query_runner/dgraph.py Outdated Show resolved Hide resolved
redash/query_runner/dgraph.py Outdated Show resolved Hide resolved
@arikfr arikfr merged commit 69ba165 into getredash:master Aug 13, 2019
@arikfr
Copy link
Member

arikfr commented Aug 13, 2019

Merged. Thanks!

harveyrendell pushed a commit to pushpay/redash that referenced this pull request Nov 14, 2019
* Initial commit for adding Dgraph support

* Made suggestions from https://codeclimate.com/github/getredash/redash/pull/3964

* feedback from @arikfr

* added logo for Dgraph from Twitter

* Better conversion of Dgraph JSON to Redash's internal JSON

* made recommendations from @arikfr

* removed unused function
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants