-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Data Sources] Initial commit for adding Dgraph support #3987
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How do queries look like in Dgraph? I mean, what type of query language does it use?
Dgraph uses a variant of GraphQL they call GraphQL+- (https://docs.dgraph.io/query-language/). The output is JSON. There might be a syntax highlighter for GraphQL+-. Should that be part of this PR, or a separate one? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your continued effort on this! I think this is the last round of comments before merging it in 👌
Merged. Thanks! |
* Initial commit for adding Dgraph support * Made suggestions from https://codeclimate.com/github/getredash/redash/pull/3964 * feedback from @arikfr * added logo for Dgraph from Twitter * Better conversion of Dgraph JSON to Redash's internal JSON * made recommendations from @arikfr * removed unused function
What type of PR is this? (check all applicable)
Description
Adding support for querying Dgraph.
Original PR was #3964