Cypress: Fix cy.clock not freezing time #4060
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ranbena
approved these changes
Aug 13, 2019
I initially thought that as well, I was surprised that Cypress pointed me to remove the workarounds. My guess is that |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
Description
With this I noticed that time wasn't being frozen after using
cy.clock(it was set, but some second differences were happening). In order to properly set that it must come beforecy.visit, but this was causing page loading issues. Solved those by usingcy.clock(timestamp, ['Date'])so theDateelement is affected and other Timer functions are not.Note: Could remove all workarounds after that 🙂
Related Tickets & Documents
--
Mobile & Desktop Screenshots/Recordings (if there are UI changes)
--