Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fork keep visualizations order #4067

Merged
merged 4 commits into from
Aug 14, 2019

Conversation

Jakdaw
Copy link
Contributor

@Jakdaw Jakdaw commented Aug 13, 2019

What type of PR is this? (check all applicable)

  • Bug Fix

Description

At present when a query is forked the new query might not have the visualisations in the same order as in the original query. There's no way to reorder them in the UI, so let's make sure we maintain the same order.

Related Tickets & Documents

Mobile & Desktop Screenshots/Recordings (if there are UI changes)

@kravets-levko kravets-levko requested review from arikfr and rauchy August 13, 2019 18:11
@rauchy
Copy link
Contributor

rauchy commented Aug 13, 2019

LGTM. Wondering in what scenarios are forked visualizations ordered differently though?

@kravets-levko
Copy link
Collaborator

kravets-levko commented Aug 13, 2019

Wondering in what scenarios are forked visualizations ordered differently though?

Generally, if you omit ORDER BY clause from SQL query, order of records is undefined (DB engine can return records in any order). Usually (but not a must) DB will return records ordered by primary key or any other key used to process the query.

@arikfr arikfr merged commit d49514a into getredash:master Aug 14, 2019
@arikfr
Copy link
Member

arikfr commented Aug 14, 2019

Thanks!

You might want to associate the email address in your Git commit with your GitHub account so this is probably represented in the contributors tab here.

harveyrendell pushed a commit to pushpay/redash that referenced this pull request Nov 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants