Rockset data source improvements #4076
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
August 16, 2019 14:39
|
@arikfr we'd appreciate it if someone can please take a look at this! :) |
arikfr
reviewed
Aug 28, 2019
| columns = list(set(map(lambda x: x['field'][0], describe['results']))) | ||
| schema[table_name] = {'name': table_name, 'columns': columns} | ||
| return schema.values() | ||
| pool = ThreadPool(processes=10) |
There was a problem hiding this comment.
In some configurations (and this is going to become the default) we run Redash's API server with gevent's monkeypatching. I'm not sure how "healthy" it is to mix threads with gevent.
How about we land this PR without the threads optimization and then revisit this in a follow up?
There was a problem hiding this comment.
At the moment the default deployment doesn't use gevent and we don't have a timeline for the switch. So for now I suggest we don't use anything that depends on it.
|
@arikfr thoughts on ^? |
|
@arikfr would appreciate some direction here, thanks. |
|
Abandoning in favor of a simpler PR coming later today |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
Description
This updates the Rockset data source in 2 important ways
commonsworkspace was loaded and others were ignoredRelated Tickets & Documents
N/A
Mobile & Desktop Screenshots/Recordings (if there are UI changes)
N/A