Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alerts first-timers-only #4220

Closed
wants to merge 4 commits into from
Closed

Alerts first-timers-only #4220

wants to merge 4 commits into from

Conversation

sahilmalhotra24
Copy link

@sahilmalhotra24 sahilmalhotra24 commented Oct 7, 2019

What type of PR is this? (check all applicable)

  • Refactor
  • Feature
  • Bug Fix
  • New Query Runner (Data Source)
  • New Alert Destination
  • Other

Description

Related Tickets & Documents

Mobile & Desktop Screenshots/Recordings (if there are UI changes)

Can i use this Redash in LWC (that is lightning web Component?)

@ranbena
Copy link
Contributor

ranbena commented Oct 7, 2019

Hey @sahilmalhotra24, if I understand correctly (the PR description quite lacking), you converted the query selector to be the dedicated component.

I've been working on redesigning the alert page and migrating it to React, including QuerySelector.
Hoping to land #4153 very soon.
So, this PR might be redundant I'm afraid.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants