-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Multiprocess RQ workers #4233
Closed
Closed
Multiprocess RQ workers #4233
Changes from all commits
Commits
Show all changes
43 commits
Select commit
Hold shift + click to select a range
824977b
add rq and an rq_worker service
7a59a1a
add rq_scheduler and an rq_scheduler service
4a7c7b7
move beat schedule to periodic_jobs queue
965ad8a
move version checks to RQ
13c2891
move query result cleanup to RQ
2b070f3
move custom tasks to RQ
6479c1f
do actual schema refreshes in rq
c368833
move send_email to rq
af94ea9
DRY up enqueues
d9f6d31
ditch and use a partially applied decorator
8257983
👋 beat
c906b36
rename rq_scheduler to plain scheduler, now that there's no Celery sc…
6b72ff6
add logging context to rq jobs (while keeping execute_query context v…
6073a41
move schedule to its own module
a627080
cancel previously scheduled periodic jobs. not sure this is a good idea.
1581920
rename redash.scheduler to redash.schedule
67ff9e1
allow custom dynamic jobs to be added decleratively
4116fe5
pleasing the CodeClimate overlords
a5adbf3
adjust cypress docker-compose.yml to include rq changes
97a3dac
DRY up Cypress docker-compose
9d50738
an odd attempt at watching docker-compose logs when running with Cypress
3c4d25c
Revert "an odd attempt at watching docker-compose logs when running w…
f714dd6
show docker-compose logs at Cypress shutdown
6c40c4e
Revert "DRY up Cypress docker-compose"
77df227
minimal version for binding is 3.2
0540472
remove unneccesary code reloads on cypress
ec5afb4
SCHEMAS_REFRESH_QUEUE is no longer a required setting
814110f
split tasks/queries.py to execution.py and maintenance.py
f7fa7dc
rename worker to celery_worker and rq_worker to worker
47c5287
delete all existing periodic jobs before scheduling them
c3d43c7
remove some unrequired requires
a16e392
move schedule example to redash.schedule
2aae335
pleasing the CodeClimate overlords
0be56a5
revert to calling a function in dynamic settings to allow periodic jo…
5c499c8
set the timeout_ttl to double the interval to avoid job results from …
9f5a68e
a naive way to launch multiple workers in one container
1e44681
updated and less brittle healthcheck
7479493
describe custom jobs and don't actually schedule them
91a2eff
launch multiple workers with Honcho
d0e3721
fix my faulty rebase
770eaa2
restart all workers when a worker dies
306e258
Revert "restart all workers when a worker dies"
d5c5411
optimize work horse initialization by configuration mappers on the wo…
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should probably move this to its own PR, so it's not forgotten in case we abandon this one.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🙊#4314
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oops :-)