New feature - Alert muting #4276
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ranbena
commented
Oct 22, 2019
ranbena
commented
Oct 22, 2019
| right: 14px; | ||
| top: 9px; | ||
| right: 0; | ||
| top:-33px; |
There was a problem hiding this comment.
This just locks the "+Add" button to its parent instead of the whole wrapper.
Needed cause this section gets pushed down by the "Notifications are muted" block.
|
@arikfr requesting your review |
arikfr
previously requested changes
Oct 29, 2019
arikfr
approved these changes
Nov 2, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added ability to mute alert.
UX discussion in https://discuss.redash.io/t/alert-feature-toggle-notifications-on-off/4704/4
Added "Mute Notifications" to the menu button, with an extra unmute button in the prompt:
Alerts list page also shows muted status:
In action: